commit db510ca8052884fd260f425025bacf44f6c92fa9
author Christian Brabandt <cb@256bit.org> Sun Sep 03 09:23:12 2023 +0200
committer Christian Brabandt <cb@256bit.org> Sun Sep 03 09:30:09 2023 +0200
tree 1f60b8dd639b78bb6fc21521578d6d0c7e052d5f
parent 15cbaae31382f17c96a4519e334dd7ba4a90ecba

patch 9.0.1854: test_crash1() fails on CI

Problem:  test_crash1() fails on CI
Solution: don't run Screendump test, verify that it doesn't crash
          by running it through a shell command line, testing
          the exit value and concatenating success cmd using '&&'

Signed-off-by: Christian Brabandt <cb@256bit.org>

src/testdir/test_crash.vim

diff --git a/src/testdir/test_crash.vim b/src/testdir/test_crash.vim
index 445fe8d..eb3c0a3 100644
--- a/src/testdir/test_crash.vim
+++ b/src/testdir/test_crash.vim
@@ -6,20 +6,40 @@
 
 func Test_crash1()
   " The following used to crash Vim
-  let opts = #{wait_for_ruler: 0, rows: 20}
-  let args = ' -u NONE -i NONE -n -e -s -S '
-  let buf = RunVimInTerminal(args .. ' crash/poc_huaf1', opts)
-  call VerifyScreenDump(buf, 'Test_crash_01', {})
+  " let opts = #{wait_for_ruler: 0, rows: 20, cmd: 'sh'}
+  let opts = #{cmd: 'sh'}
+  let args = 'bash'
+  let vim  = GetVimProg()
+
+  let buf = RunVimInTerminal(args, opts)
+
+  let file = 'crash/poc_huaf1'
+  let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'"
+  let args = printf(cmn_args, vim, file)
+  call term_sendkeys(buf, args ..
+    \ '  && echo "crash 1: [OK]" >> X_crash1_result.txt' .. "\<cr>")
+
+  let file = 'crash/poc_huaf2'
+  let args = printf(cmn_args, vim, file)
+  call term_sendkeys(buf, args ..
+    \ '  && echo "crash 2: [OK]" >> X_crash1_result.txt' .. "\<cr>")
+
+  let file = 'crash/poc_huaf3'
+  let args = printf(cmn_args, vim, file)
+  call term_sendkeys(buf, args ..
+    \ '  && echo "crash 3: [OK]" >> X_crash1_result.txt' .. "\<cr>")
+
+  call TermWait(buf, 50)
+
+  " clean up
   exe buf .. "bw!"
 
-  let buf = RunVimInTerminal(args .. ' crash/poc_huaf2', opts)
-  call VerifyScreenDump(buf, 'Test_crash_01', {})
-  exe buf .. "bw!"
+  sp X_crash1_result.txt
+  call assert_equal(['crash 1: [OK]', 'crash 2: [OK]', 'crash 3: [OK]'],
+    \ getline(1, '$'))
+  bw!
 
-  let buf = RunVimInTerminal(args .. ' crash/poc_huaf3', opts)
-  call VerifyScreenDump(buf, 'Test_crash_01', {})
-  exe buf .. "bw!"
-
+  call delete('X_crash1_result.txt')
 endfunc
 
 func Test_crash2()

src/version.c

diff --git a/src/version.c b/src/version.c
index fe1495a..c1f72ff 100644
--- a/src/version.c
+++ b/src/version.c
@@ -700,6 +700,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1854,
+/**/
     1853,
 /**/
     1852,