patch 9.0.0214: splitting a line may duplicate virtual text
Problem: Splitting a line may duplicate virtual text. (Ben Jackson)
Solution: Don't duplicate a text property with virtual text. Make
auto-indenting work better. (closes #10919)
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_1.dump b/src/testdir/dumps/Test_prop_insert_start_incl_1.dump
index deb67d5..de1f3d4 100644
--- a/src/testdir/dumps/Test_prop_insert_start_incl_1.dump
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_1.dump
@@ -1,8 +1,8 @@
|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| >o+0#0000000&|n|e| |t|e|x|t| |b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @29
+@60
+|f|u|n|c|t|i|o|n|(|a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @41
|~+0#4040ff13&| @58
|~| @58
|~| @58
|~| @58
-|~| @58
-|~| @58
| +0#0000000&@41|1|,|6|-|1|2| @7|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_2.dump b/src/testdir/dumps/Test_prop_insert_start_incl_2.dump
index 73cf648..f0c9ac0 100644
--- a/src/testdir/dumps/Test_prop_insert_start_incl_2.dump
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_2.dump
@@ -1,8 +1,8 @@
|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| >o+0#0000000&|n|e| |t|e|x|t| |b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @29
+@60
+|f|u|n|c|t|i|o|n|(|a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @41
|~+0#4040ff13&| @58
|~| @58
|~| @58
|~| @58
-|~| @58
-|~| @58
|-+2#0000000&@1| |I|N|S|E|R|T| |-@1| +0&&@29|1|,|6|-|1|2| @7|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_3.dump b/src/testdir/dumps/Test_prop_insert_start_incl_3.dump
index cc4de01..5a8578b 100644
--- a/src/testdir/dumps/Test_prop_insert_start_incl_3.dump
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_3.dump
@@ -1,8 +1,8 @@
|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&>x|o|n|e| |t|e|x|t| |b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @27
+@60
+|f|u|n|c|t|i|o|n|(|a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @41
|~+0#4040ff13&| @58
|~| @58
|~| @58
|~| @58
-|~| @58
-|~| @58
| +0#0000000&@41|1|,|7|-|1|3| @7|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_4.dump b/src/testdir/dumps/Test_prop_insert_start_incl_4.dump
index 75e2580..bf67a1e 100644
--- a/src/testdir/dumps/Test_prop_insert_start_incl_4.dump
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_4.dump
@@ -1,8 +1,8 @@
|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&@1|o|n|e| |t|e|x|t| >b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @27
+@60
+|f|u|n|c|t|i|o|n|(|a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @41
|~+0#4040ff13&| @58
|~| @58
|~| @58
|~| @58
-|~| @58
-|~| @58
|-+2#0000000&@1| |I|N|S|E|R|T| |-@1| +0&&@29|1|,|1|7|-|2|3| @6|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_5.dump b/src/testdir/dumps/Test_prop_insert_start_incl_5.dump
index 5cbee12..270c8a0 100644
--- a/src/testdir/dumps/Test_prop_insert_start_incl_5.dump
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_5.dump
@@ -1,8 +1,8 @@
|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&@1|o|n|e| |t|e|x|t| |y>y|b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @25
+@60
+|f|u|n|c|t|i|o|n|(|a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @41
|~+0#4040ff13&| @58
|~| @58
|~| @58
|~| @58
-|~| @58
-|~| @58
| +0#0000000&@41|1|,|1|8|-|2|4| @6|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_6.dump b/src/testdir/dumps/Test_prop_insert_start_incl_6.dump
new file mode 100644
index 0000000..96156a8
--- /dev/null
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_6.dump
@@ -0,0 +1,8 @@
+|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&@1|o|n|e| |t|e|x|t| |y@1|b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @25
+@60
+|f|u|n|c|t|i|o|n|(| @50
+@7> |a+0&#ffd7ff255|r|g|:| |a+0&#ffffff0|r|g|)| @42
+|~+0#4040ff13&| @58
+|~| @58
+|~| @58
+| +0#0000000&@41|4|,|1|-|8| @8|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_7.dump b/src/testdir/dumps/Test_prop_insert_start_incl_7.dump
new file mode 100644
index 0000000..43545a8
--- /dev/null
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_7.dump
@@ -0,0 +1,8 @@
+|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&@1|o|n|e| |t|e|x|t| |y@1|b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @25
+@60
+|f|u|n|c|t|i|o|n|(| @50
+@12|a+0&#ffd7ff255|r|g|:| >a+0&#ffffff0|r|g|)| @38
+|~+0#4040ff13&| @58
+|~| @58
+|~| @58
+| +0#0000000&@41|4|,|6|-|1|8| @7|A|l@1|
diff --git a/src/testdir/dumps/Test_prop_insert_start_incl_8.dump b/src/testdir/dumps/Test_prop_insert_start_incl_8.dump
new file mode 100644
index 0000000..9d46839
--- /dev/null
+++ b/src/testdir/dumps/Test_prop_insert_start_incl_8.dump
@@ -0,0 +1,8 @@
+|t+0&#ffffff0|e|x|t| |a+0#4040ff13&|f|t|e|r| |x+0#0000000&@1|o|n|e| |t|e|x|t| |y@1|b+0#4040ff13&|e|f|o|r|e| |t+0#0000000&|w|o| @25
+@60
+|f|u|n|c|t|i|o|n|(| @50
+@4|a+0&#ffd7ff255|r|g|:| >a+0&#ffffff0|r|g|)| @46
+|~+0#4040ff13&| @58
+|~| @58
+|~| @58
+| +0#0000000&@41|4|,|5|-|1|0| @7|A|l@1|
diff --git a/src/testdir/test_textprop.vim b/src/testdir/test_textprop.vim
index c380210..496e738 100644
--- a/src/testdir/test_textprop.vim
+++ b/src/testdir/test_textprop.vim
@@ -2943,13 +2943,17 @@
let lines =<< trim END
vim9script
- setline(1, 'text one text two')
+ setline(1, ['text one text two', '', 'function(arg)'])
prop_type_add('propincl', {highlight: 'NonText', start_incl: true})
prop_add(1, 6, {type: 'propincl', text: 'after '})
cursor(1, 6)
prop_type_add('propnotincl', {highlight: 'NonText', start_incl: false})
prop_add(1, 15, {type: 'propnotincl', text: 'before '})
+
+ set cindent sw=4
+ prop_type_add('argname', {highlight: 'DiffChange', start_incl: true})
+ prop_add(3, 10, {type: 'argname', text: 'arg: '})
END
call writefile(lines, 'XscriptPropsStartIncl')
let buf = RunVimInTerminal('-S XscriptPropsStartIncl', #{rows: 8, cols: 60})
@@ -2965,6 +2969,13 @@
call term_sendkeys(buf, "yy\<Esc>")
call VerifyScreenDump(buf, 'Test_prop_insert_start_incl_5', {})
+ call term_sendkeys(buf, "3Gfai\<CR>\<Esc>")
+ call VerifyScreenDump(buf, 'Test_prop_insert_start_incl_6', {})
+ call term_sendkeys(buf, ">>")
+ call VerifyScreenDump(buf, 'Test_prop_insert_start_incl_7', {})
+ call term_sendkeys(buf, "<<<<")
+ call VerifyScreenDump(buf, 'Test_prop_insert_start_incl_8', {})
+
call StopVimInTerminal(buf)
call delete('XscriptPropsStartIncl')
endfunc