commit d6a7b3e6bbb8f87507de68d86cf70eab806aab3a
author Bram Moolenaar <Bram@vim.org> Sat Aug 19 21:35:35 2017 +0200
committer Bram Moolenaar <Bram@vim.org> Sat Aug 19 21:35:35 2017 +0200
tree 7c223144fa8f8b7372b9e6f183633aa53de4cebe
parent dc926dd0dd0ef72fe7993f134f2cc1551cd269ea

patch 8.0.0970: passing invalid highlight id

Problem:    if there is no StatusLine highlighting and there is StatusLineNC
            or StatusLineTermNC highlighting then an invalid highlight id is
            passed to combine_stl_hlt(). (Coverity)
Solution:   Check id_S to be -1 instead of zero.

src/syntax.c

diff --git a/src/syntax.c b/src/syntax.c
index 637a450..7303575 100644
--- a/src/syntax.c
+++ b/src/syntax.c
@@ -9999,7 +9999,7 @@
     if (ga_grow(&highlight_ga, 28) == FAIL)
 	return FAIL;
     hlcnt = highlight_ga.ga_len;
-    if (id_S == 0)
+    if (id_S == -1)
     {
 	/* Make sure id_S is always valid to simplify code below. Use the last
 	 * entry. */