patch 8.1.0633: crash when out of memory while opening a terminal window
Problem: Crash when out of memory while opening a terminal window.
Solution: Handle out-of-memory more gracefully.
diff --git a/src/terminal.c b/src/terminal.c
index 06d470c..1875cc3 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -3430,6 +3430,7 @@
{
int index = 0;
VTermState *state = vterm_obtain_state(vterm);
+
for (; index < 16; index++)
{
VTermColor color;
@@ -3703,8 +3704,9 @@
/*
* Create a new vterm and initialize it.
+ * Return FAIL when out of memory.
*/
- static void
+ static int
create_vterm(term_T *term, int rows, int cols)
{
VTerm *vterm;
@@ -3714,7 +3716,18 @@
vterm = vterm_new_with_allocator(rows, cols, &vterm_allocator, NULL);
term->tl_vterm = vterm;
+ if (vterm == NULL)
+ return FAIL;
+
+ // Allocate screen and state here, so we can bail out if that fails.
+ state = vterm_obtain_state(vterm);
screen = vterm_obtain_screen(vterm);
+ if (state == NULL || screen == NULL)
+ {
+ vterm_free(vterm);
+ return FAIL;
+ }
+
vterm_screen_set_callbacks(screen, &screen_callbacks, term);
/* TODO: depends on 'encoding'. */
vterm_set_utf8(vterm, 1);
@@ -3722,7 +3735,7 @@
init_default_colors(term);
vterm_state_set_default_colors(
- vterm_obtain_state(vterm),
+ state,
&term->tl_default_color.fg,
&term->tl_default_color.bg);
@@ -3746,9 +3759,10 @@
#else
value.boolean = 0;
#endif
- state = vterm_obtain_state(vterm);
vterm_state_set_termprop(state, VTERM_PROP_CURSORBLINK, &value);
vterm_state_set_unrecognised_fallbacks(state, &parser_fallbacks, term);
+
+ return OK;
}
/*
@@ -5629,7 +5643,8 @@
vim_free(cwd_wchar);
vim_free(env_wchar);
- create_vterm(term, term->tl_rows, term->tl_cols);
+ if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)
+ goto failed;
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
if (opt->jo_set2 & JO2_ANSI_COLORS)
@@ -5710,7 +5725,8 @@
char in_name[80], out_name[80];
channel_T *channel = NULL;
- create_vterm(term, term->tl_rows, term->tl_cols);
+ if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)
+ return FAIL;
vim_snprintf(in_name, sizeof(in_name), "\\\\.\\pipe\\vim-%d-in-%d",
GetCurrentProcessId(),
@@ -5822,7 +5838,8 @@
jobopt_T *opt,
jobopt_T *orig_opt UNUSED)
{
- create_vterm(term, term->tl_rows, term->tl_cols);
+ if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)
+ return FAIL;
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
if (opt->jo_set2 & JO2_ANSI_COLORS)
@@ -5844,7 +5861,8 @@
static int
create_pty_only(term_T *term, jobopt_T *opt)
{
- create_vterm(term, term->tl_rows, term->tl_cols);
+ if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)
+ return FAIL;
term->tl_job = job_alloc();
if (term->tl_job == NULL)