commit cb54bc65625abad9a0af501acac5c70fba17e2cc
author Dominique Pelle <dominique.pelle@gmail.com> Mon Jun 21 20:15:37 2021 +0200
committer Bram Moolenaar <Bram@vim.org> Mon Jun 21 20:15:37 2021 +0200
tree 8a77eccb36f2e2102ec2b67a947b26b618748dd6
parent 035bd1c99f2a8eda5ee886adde4f97ea71fb167f

patch 8.2.3030: Coverity reports a memory leak

Problem:    Coverity reports a memory leak.
Solution:   Fix the leak and a few typos. (Dominique Pellé, closes #8418)

src/crypt.c

diff --git a/src/crypt.c b/src/crypt.c
index 35d4e14..f844e42 100644
--- a/src/crypt.c
+++ b/src/crypt.c
@@ -819,19 +819,19 @@
     if (sod_st->count && len <= crypto_secretstream_xchacha20poly1305_ABYTES)
     {
 	emsg(e_libsodium_cannot_decrypt_buffer);
-	return;
+	goto fail;
     }
     if (crypto_secretstream_xchacha20poly1305_pull(&sod_st->state,
 			     buf_out, &buf_len, &tag, from, len, NULL, 0) != 0)
     {
-	emsg(e_libsodium_decription_failed);
+	emsg(e_libsodium_decryption_failed);
 	goto fail;
     }
     sod_st->count++;
 
     if (tag == crypto_secretstream_xchacha20poly1305_TAG_FINAL && !last)
     {
-	emsg(e_libsodium_decyption_failed_premature);
+	emsg(e_libsodium_decryption_failed_premature);
 	goto fail;
     }
     if (p1 == p2)
@@ -931,12 +931,12 @@
     if (crypto_secretstream_xchacha20poly1305_pull(&sod_st->state,
 			    *buf_out, &out_len, &tag, from, len, NULL, 0) != 0)
     {
-	emsg(e_libsodium_decription_failed);
+	emsg(e_libsodium_decryption_failed);
 	return -1;
     }
 
     if (tag == crypto_secretstream_xchacha20poly1305_TAG_FINAL && !last)
-	emsg(e_libsodium_decyption_failed_premature);
+	emsg(e_libsodium_decryption_failed_premature);
     return (long) out_len;
 # else
     return -1;

src/errors.h

diff --git a/src/errors.h b/src/errors.h
index cb93efd..9663ecd 100644
--- a/src/errors.h
+++ b/src/errors.h
@@ -442,7 +442,7 @@
 	INIT(= N_("E1198: Decryption failed: Header incomplete!"));
 EXTERN char e_libsodium_cannot_decrypt_buffer[]
 	INIT(= N_("E1199: Cannot decrypt buffer, not enough space"));
-EXTERN char e_libsodium_decription_failed[]
+EXTERN char e_libsodium_decryption_failed[]
 	INIT(= N_("E1200: Decryption failed: corrupted chunk!"));
-EXTERN char e_libsodium_decyption_failed_premature[]
+EXTERN char e_libsodium_decryption_failed_premature[]
 	INIT(= N_("E1201: Decryption failed: pre-mature end of file!"));

src/version.c

diff --git a/src/version.c b/src/version.c
index 096235f..0c3c887 100644
--- a/src/version.c
+++ b/src/version.c
@@ -756,6 +756,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    3030,
+/**/
     3029,
 /**/
     3028,