commit ca195cc84fb3f5e497cdbc5f1f53dc1d7efedf48
author Yegappan Lakshmanan <yegappan@yahoo.com> Tue Jun 14 13:42:26 2022 +0100
committer Bram Moolenaar <Bram@vim.org> Tue Jun 14 13:42:26 2022 +0100
tree 709beb58d68cd3433060720a1c81cbfe6228715f
parent cd7496382efc9e6748326c6cda7f01003fa07063

patch 8.2.5089: some functions return a different value on failure

Problem:    Some functions return a different value on failure.
Solution:   Initialize the return value earlier. (Yegappan Lakshmanan,
            closes #10568)

src/dict.c

diff --git a/src/dict.c b/src/dict.c
index 538dd8b..d281957 100644
--- a/src/dict.c
+++ b/src/dict.c
@@ -1457,6 +1457,9 @@
     dict_T	*d;
     int		todo;
 
+    if (rettv_list_alloc(rettv) == FAIL)
+	return;
+
     if (in_vim9script() && check_for_dict_arg(argvars, 0) == FAIL)
 	return;
 
@@ -1466,8 +1469,6 @@
 	return;
     }
 
-    if (rettv_list_alloc(rettv) == FAIL)
-	return;
     if ((d = argvars[0].vval.v_dict) == NULL)
 	// empty dict behaves like an empty dict
 	return;