commit c99e182e1fb54e39540d25d0ccd8dcdde25bb96c
author Yegappan Lakshmanan <yegappan@yahoo.com> Sat Sep 03 10:52:24 2022 +0100
committer Bram Moolenaar <Bram@vim.org> Sat Sep 03 10:52:24 2022 +0100
tree d0cec00ea2cd55d8fb68d353712b70d8be952e5f
parent b18b49699776485150b71626069a40d12d2c5590

patch 9.0.0364: clang static analyzer gives warnings

Problem:    Clang static analyzer gives warnings.
Solution:   Avoid the warnings. (Yegappan Lakshmanan, closes #11043)

src/vim9compile.c

diff --git a/src/vim9compile.c b/src/vim9compile.c
index 2036675..a785ba9 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -2243,9 +2243,9 @@
 			r = compile_expr0_ext(&p, cctx, &is_const);
 			if (lhs.lhs_new_local)
 			    ++cctx->ctx_locals.ga_len;
-			if (r == FAIL)
-			    goto theend;
 		    }
+		    if (r == FAIL)
+			goto theend;
 		}
 		else if (semicolon && var_idx == var_count - 1)
 		{