commit c816a2c22667108fcd61f445de2c926f78ff9fa7
author Bram Moolenaar <Bram@vim.org> Wed Jul 14 21:00:41 2021 +0200
committer Bram Moolenaar <Bram@vim.org> Wed Jul 14 21:00:41 2021 +0200
tree f6b7fe9ee819ac64e1c2602a52c5c66ae1a0390d
parent 4a0b85ad0193ac162e2d8458e4b1c5ad2e2b0193

patch 8.2.3161: Vim9: no error when reltime() has invalid arguments

Problem:    Vim9: no error when reltime() has invalid arguments.
Solution:   Add an error. (closes #8562)

src/testdir/test_vim9_builtin.vim

diff --git a/src/testdir/test_vim9_builtin.vim b/src/testdir/test_vim9_builtin.vim
index 03bc3fb..f5315f9 100644
--- a/src/testdir/test_vim9_builtin.vim
+++ b/src/testdir/test_vim9_builtin.vim
@@ -1652,6 +1652,11 @@
 enddef
 
 def Test_reltime()
+  CheckFeature reltime
+
+  CheckDefExecAndScriptFailure(['[]->reltime()'], 'E474:')
+  CheckDefExecAndScriptFailure(['[]->reltime([])'], 'E474:')
+
   CheckDefFailure(['reltime("x")'], 'E1013: Argument 1: type mismatch, expected list<number> but got string')
   CheckDefFailure(['reltime(["x", "y"])'], 'E1013: Argument 1: type mismatch, expected list<number> but got list<string>')
   CheckDefFailure(['reltime([1, 2], 10)'], 'E1013: Argument 2: type mismatch, expected list<number> but got number')
@@ -1663,12 +1668,20 @@
 enddef
 
 def Test_reltimefloat()
+  CheckFeature reltime
+
+  CheckDefExecAndScriptFailure(['[]->reltimefloat()'], 'E474:')
+
   CheckDefFailure(['reltimefloat("x")'], 'E1013: Argument 1: type mismatch, expected list<number> but got string')
   CheckDefFailure(['reltimefloat([1.1])'], 'E1013: Argument 1: type mismatch, expected list<number> but got list<float>')
   assert_true(type(reltimefloat(reltime())) == v:t_float)
 enddef
 
 def Test_reltimestr()
+  CheckFeature reltime
+
+  CheckDefExecAndScriptFailure(['[]->reltimestr()'], 'E474:')
+
   CheckDefFailure(['reltimestr(true)'], 'E1013: Argument 1: type mismatch, expected list<number> but got bool')
   CheckDefFailure(['reltimestr([true])'], 'E1013: Argument 1: type mismatch, expected list<number> but got list<bool>')
   assert_true(type(reltimestr(reltime())) == v:t_string)

src/time.c

diff --git a/src/time.c b/src/time.c
index 6d4ad5d..02c5da9 100644
--- a/src/time.c
+++ b/src/time.c
@@ -178,7 +178,11 @@
     else if (argvars[1].v_type == VAR_UNKNOWN)
     {
 	if (list2proftime(&argvars[0], &res) == FAIL)
+	{
+	    if (in_vim9script())
+		emsg(_(e_invarg));
 	    return;
+	}
 	profile_end(&res);
     }
     else
@@ -186,7 +190,11 @@
 	// Two arguments: compute the difference.
 	if (list2proftime(&argvars[0], &start) == FAIL
 		|| list2proftime(&argvars[1], &res) == FAIL)
+	{
+	    if (in_vim9script())
+		emsg(_(e_invarg));
 	    return;
+	}
 	profile_sub(&res, &start);
     }
 
@@ -223,6 +231,8 @@
 #  ifdef FEAT_RELTIME
     if (list2proftime(&argvars[0], &tm) == OK)
 	rettv->vval.v_float = profile_float(&tm);
+    else if (in_vim9script())
+	emsg(_(e_invarg));
 #  endif
 }
 # endif
@@ -242,6 +252,8 @@
 # ifdef FEAT_RELTIME
     if (list2proftime(&argvars[0], &tm) == OK)
 	rettv->vval.v_string = vim_strsave((char_u *)profile_msg(&tm));
+    else if (in_vim9script())
+	emsg(_(e_invarg));
 # endif
 }
 

src/version.c

diff --git a/src/version.c b/src/version.c
index e20a32c..7e3455d 100644
--- a/src/version.c
+++ b/src/version.c
@@ -756,6 +756,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    3161,
+/**/
     3160,
 /**/
     3159,