patch 8.2.4629: flattennew() makes a deep copy unnecessarily
Problem: flattennew() makes a deep copy unnecessarily.
Solution: Use a shallow copy. (issue #10012)
diff --git a/src/list.c b/src/list.c
index 9309048..3354068 100644
--- a/src/list.c
+++ b/src/list.c
@@ -925,7 +925,6 @@
list_flatten(list_T *list, listitem_T *first, long maxitems, long maxdepth)
{
listitem_T *item;
- listitem_T *tofree;
int done = 0;
if (maxdepth == 0)
@@ -955,13 +954,12 @@
return;
}
clear_tv(&item->li_tv);
- tofree = item;
if (maxdepth > 0)
list_flatten(list, item->li_prev == NULL
? list->lv_first : item->li_prev->li_next,
itemlist->lv_len, maxdepth - 1);
- list_free_item(list, tofree);
+ list_free_item(list, item);
}
++done;
@@ -1012,7 +1010,7 @@
if (make_copy)
{
- l = list_copy(l, TRUE, TRUE, get_copyID());
+ l = list_copy(l, FALSE, TRUE, get_copyID());
rettv->vval.v_list = l;
if (l == NULL)
return;