patch 9.0.1741: No type checking in interfaces
Problem: No type checking in interfaces
Solution: Implement member type check in vim9 interfaces
Most of the code is a small refactoring to allow the use of a where_T
for signaling the type mismatch, the type checking itself is pretty
simple.
Improve where_T error reports
Let the caller explicitly define the kind of location it's referring to
and free the WT_ARGUMENT enum from its catch-all role.
Implement type checking for interface methods
Follows closely the logic used for type-checking the members.
closes: #12844
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: LemonBoy <thatlemon@gmail.com>
diff --git a/src/vim9compile.c b/src/vim9compile.c
index e666357..028b0ca 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -496,7 +496,7 @@
if (!actual_is_const && ret == MAYBE && use_typecheck(actual, expected))
{
generate_TYPECHECK(cctx, expected, number_ok, offset,
- where.wt_variable, where.wt_index);
+ where.wt_kind == WT_VARIABLE, where.wt_index);
return OK;
}
@@ -518,7 +518,11 @@
{
where_T where = WHERE_INIT;
- where.wt_index = arg_idx;
+ if (arg_idx > 0)
+ {
+ where.wt_index = arg_idx;
+ where.wt_kind = WT_ARGUMENT;
+ }
return need_type_where(actual, expected, number_ok, offset, where,
cctx, silent, actual_is_const);
}
@@ -2636,8 +2640,11 @@
// Without operator check type here, otherwise below.
// Use the line number of the assignment.
SOURCING_LNUM = start_lnum;
- where.wt_index = var_count > 0 ? var_idx + 1 : 0;
- where.wt_variable = var_count > 0;
+ if (var_count > 0)
+ {
+ where.wt_index = var_idx + 1;
+ where.wt_kind = WT_VARIABLE;
+ }
// If assigning to a list or dict member, use the
// member type. Not for "list[:] =".
if (lhs.lhs_has_index
@@ -3193,6 +3200,7 @@
// specified type.
val_type = get_type_on_stack(&cctx, 0);
where.wt_index = arg_idx + 1;
+ where.wt_kind = WT_ARGUMENT;
if (ufunc->uf_arg_types[arg_idx] == &t_unknown)
{
did_set_arg_type = TRUE;