patch 9.1.1512: completion: can only complete from keyword characters
Problem: completion: can only complete from keyword characters
Solution: remove this restriction, allow completion functions when
called from i_CTRL-N/i_CTRL-P to be triggered from non-keyword
characters (Girish Palya)
Previously, functions specified in the `'complete'` option were
restricted to starting completion only from keyword characters (as
introduced in PR 17065). This change removes that restriction.
With this change, user-defined functions (e.g., `omnifunc`, `userfunc`)
used in `'complete'` can now initiate completion even when triggered
from non-keyword characters. This makes it easier to reuse existing
functions alongside other sources without having to consider whether the
cursor is on a keyword or non-keyword character, or worry about where
the replacement should begin (i.e., the `findstart=1` return value).
The logic for both the “collection” and “filtering” phases now fully
respects each source’s specified start column. This also extends to
fuzzy matching, making completions more predictable.
Internally, this builds on previously merged infrastructure that tracks
per-source metadata. This PR focuses on applying that metadata to
compute the leader string and insertion text appropriately for each
match.
Also, a memory corruption has been fixed in prepare_cpt_compl_funcs().
closes: #17651
Signed-off-by: Girish Palya <girishji@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
diff --git a/runtime/doc/insert.txt b/runtime/doc/insert.txt
index da028e8..df0cff9 100644
--- a/runtime/doc/insert.txt
+++ b/runtime/doc/insert.txt
@@ -1,4 +1,4 @@
-*insert.txt* For Vim version 9.1. Last change: 2025 Jun 11
+*insert.txt* For Vim version 9.1. Last change: 2025 Jul 05
VIM REFERENCE MANUAL by Bram Moolenaar
@@ -648,7 +648,7 @@
10. User defined completion |i_CTRL-X_CTRL-U|
11. omni completion |i_CTRL-X_CTRL-O|
12. Spelling suggestions |i_CTRL-X_s|
-13. keywords in 'complete' |i_CTRL-N| |i_CTRL-P|
+13. completions from 'complete' |i_CTRL-N| |i_CTRL-P|
14. contents from registers |i_CTRL-X_CTRL-R|
Additionally, |i_CTRL-X_CTRL-Z| stops completion without changing the text.
@@ -1103,25 +1103,23 @@
previous one.
-Completing keywords from different sources *compl-generic*
+Completing from different sources *compl-generic*
*i_CTRL-N*
-CTRL-N Find next match for words that start with the
- keyword in front of the cursor, looking in places
- specified with the 'complete' option. The found
- keyword is inserted in front of the cursor.
+CTRL-N Find the next match for a word ending at the cursor,
+ using the sources specified in the 'complete' option.
+ All sources complete from keywords, except functions,
+ which may complete from non-keyword. The matched
+ text is inserted before the cursor.
*i_CTRL-P*
-CTRL-P Find previous match for words that start with the
- keyword in front of the cursor, looking in places
- specified with the 'complete' option. The found
- keyword is inserted in front of the cursor.
+CTRL-P Same as CTRL-N, but find the previous match.
- CTRL-N Search forward for next matching keyword. This
- keyword replaces the previous matching keyword.
+ CTRL-N Search forward through the matches and insert the
+ next one.
- CTRL-P Search backwards for next matching keyword. This
- keyword replaces the previous matching keyword.
+ CTRL-P Search backward through the matches and insert the
+ previous one.
CTRL-X CTRL-N or
CTRL-X CTRL-P Further use of CTRL-X CTRL-N or CTRL-X CTRL-P will