commit b444ee761a2956a996a75d923281c51fa1a759f3
author zeertzjq <zeertzjq@outlook.com> Mon Feb 20 15:25:13 2023 +0000
committer Bram Moolenaar <Bram@vim.org> Mon Feb 20 15:25:13 2023 +0000
tree d69332aa7563f62546d2fca0112d121f73dc612e
parent e1121b139480f53d1b06f84f3e4574048108fa0b

patch 9.0.1332: crash when using buffer-local user command in cmdline window

Problem:    Crash when using buffer-local user command in cmdline window.
            (Karl Yngve Lervåg)
Solution:   Use the right buffer to find the user command. (closes #12030,
            closes #12029)

src/testdir/test_usercommands.vim

diff --git a/src/testdir/test_usercommands.vim b/src/testdir/test_usercommands.vim
index d8b4cb4..1e18567 100644
--- a/src/testdir/test_usercommands.vim
+++ b/src/testdir/test_usercommands.vim
@@ -856,6 +856,15 @@
   bw!
 endfunc
 
+" Test for using buffer-local user command from cmdwin.
+func Test_buflocal_usercmd_cmdwin()
+  new
+  command -buffer TestCmd edit Test
+  " This used to crash Vim
+  call assert_fails("norm q::TestCmd\<CR>", 'E11:')
+  bw!
+endfunc
+
 " Test for using a multibyte character in a user command
 func Test_multibyte_in_usercmd()
   command SubJapanesePeriodToDot exe "%s/\u3002/./g"

src/usercmd.c

diff --git a/src/usercmd.c b/src/usercmd.c
index 44fa578..7d84462 100644
--- a/src/usercmd.c
+++ b/src/usercmd.c
@@ -1838,7 +1838,7 @@
     if (eap->cmdidx == CMD_USER)
 	cmd = USER_CMD(eap->useridx);
     else
-	cmd = USER_CMD_GA(&curbuf->b_ucmds, eap->useridx);
+	cmd = USER_CMD_GA(&prevwin_curwin()->w_buffer->b_ucmds, eap->useridx);
 
     /*
      * Replace <> in the command by the arguments.

src/version.c

diff --git a/src/version.c b/src/version.c
index 4c12823..0095489 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1332,
+/**/
     1331,
 /**/
     1330,