commit b42b9fc41f27f92aaf4f96cd4149f3160e9fe588
author zeertzjq <zeertzjq@outlook.com> Mon Mar 24 20:22:23 2025 +0100
committer Christian Brabandt <cb@256bit.org> Mon Mar 24 20:22:23 2025 +0100
tree a65a92cb9d516626221ecf8ec5975a568f3fdbad
parent 92e109fc139772727783bc9f3c333e4b346e3ef4

patch 9.1.1233: Coverity warns about NULL pointer when triggering WinResized

Problem:  Coverity warns about NULL pointer when triggering WinResized
Solution: Add OOM checks for windows_list like for scroll_dict. Remove
          void casts that are unnecessary after 9.1.1084 (zeertzjq).

closes: #16959

Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

src/window.c

diff --git a/src/window.c b/src/window.c
index 55168d5..4fb7054 100644
--- a/src/window.c
+++ b/src/window.c
@@ -3285,7 +3285,8 @@
     {
 	// Create the list for v:event.windows before making the snapshot.
 	windows_list = list_alloc_with_items(size_count);
-	(void)check_window_scroll_resize(NULL, NULL, NULL, windows_list, NULL);
+	if (windows_list != NULL)
+	    check_window_scroll_resize(NULL, NULL, NULL, windows_list, NULL);
     }
 
     dict_T *scroll_dict = NULL;
@@ -3296,8 +3297,7 @@
 	if (scroll_dict != NULL)
 	{
 	    scroll_dict->dv_refcount = 1;
-	    (void)check_window_scroll_resize(NULL, NULL, NULL, NULL,
-								  scroll_dict);
+	    check_window_scroll_resize(NULL, NULL, NULL, NULL, scroll_dict);
 	}
     }
 #endif
@@ -3314,7 +3314,11 @@
     recursive = TRUE;
 
     // If both are to be triggered do WinResized first.
-    if (trigger_resize)
+    if (trigger_resize
+#ifdef FEAT_EVAL
+	    && windows_list != NULL
+#endif
+	    )
     {
 #ifdef FEAT_EVAL
 	save_v_event_T  save_v_event;