commit ac6cd31afcbdd08bfa92ca33f7d4ce5773ba4353
author zeertzjq <zeertzjq@outlook.com> Wed Apr 12 16:21:14 2023 +0100
committer Bram Moolenaar <Bram@vim.org> Wed Apr 12 16:21:14 2023 +0100
tree 3f9358e8fd2a2cf3450a79b7aa184d9224d6845d
parent 05a627c3d4e42a18f76c14828d68ee4747118211

patch 9.0.1444: crash when passing NULL to setcmdline()

Problem:    Crash when passing NULL to setcmdline(). (Andreas Louv)
Solution:   Use tv_get_string() instead of using v_string directly.
            (closes #12231, closes #12227)

src/ex_getln.c

diff --git a/src/ex_getln.c b/src/ex_getln.c
index dc933d7..36d148e 100644
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -4294,7 +4294,8 @@
 	}
     }
 
-    rettv->vval.v_number = set_cmdline_str(argvars[0].vval.v_string, pos);
+    // Use tv_get_string() to handle a NULL string like an empty string.
+    rettv->vval.v_number = set_cmdline_str(tv_get_string(&argvars[0]), pos);
 }
 
 /*

src/testdir/test_cmdline.vim

diff --git a/src/testdir/test_cmdline.vim b/src/testdir/test_cmdline.vim
index ddcb260..8b47d86 100644
--- a/src/testdir/test_cmdline.vim
+++ b/src/testdir/test_cmdline.vim
@@ -3393,6 +3393,14 @@
 
 func Test_setcmdline()
   func SetText(text, pos)
+    call assert_equal(0, setcmdline(test_null_string()))
+    call assert_equal('', getcmdline())
+    call assert_equal(1, getcmdpos())
+
+    call assert_equal(0, setcmdline(''[: -1]))
+    call assert_equal('', getcmdline())
+    call assert_equal(1, getcmdpos())
+
     autocmd CmdlineChanged * let g:cmdtype = expand('<afile>')
     call assert_equal(0, setcmdline(a:text))
     call assert_equal(a:text, getcmdline())

src/version.c

diff --git a/src/version.c b/src/version.c
index eba3db4..b5df8c5 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1444,
+/**/
     1443,
 /**/
     1442,