patch 8.2.0403: when 'buftype' is "nofile" there is no overwrite check
Problem: When 'buftype' is "nofile" there is no overwrite check.
Solution: Also check for existing file when 'buftype' is set.
(closes #5807)
diff --git a/src/ex_cmds.c b/src/ex_cmds.c
index f925378..ce5db88 100644
--- a/src/ex_cmds.c
+++ b/src/ex_cmds.c
@@ -2074,8 +2074,8 @@
int other) // writing under other name
{
/*
- * write to other file or b_flags set or not writing the whole file:
- * overwriting only allowed with '!'
+ * Write to another file or b_flags set or not writing the whole file:
+ * overwriting only allowed with '!'.
*/
if ( (other
|| (buf->b_flags & BF_NOTEDITED)
@@ -2083,9 +2083,6 @@
&& vim_strchr(p_cpo, CPO_OVERNEW) == NULL)
|| (buf->b_flags & BF_READERR))
&& !p_wa
-#ifdef FEAT_QUICKFIX
- && !bt_nofilename(buf)
-#endif
&& vim_fexists(ffname))
{
if (!eap->forceit && !eap->append)
diff --git a/src/testdir/test_options.vim b/src/testdir/test_options.vim
index 3fc0161..fbc6dc1 100644
--- a/src/testdir/test_options.vim
+++ b/src/testdir/test_options.vim
@@ -656,7 +656,15 @@
call setline(1, ['L1'])
set buftype=nowrite
call assert_fails('write', 'E382:')
- close!
+
+ for val in ['', 'nofile', 'nowrite', 'acwrite', 'quickfix', 'help', 'terminal', 'prompt', 'popup']
+ exe 'set buftype=' .. val
+ call writefile(['something'], 'XBuftype')
+ call assert_fails('write XBuftype', 'E13:', 'with buftype=' .. val)
+ endfor
+
+ call delete('XBuftype')
+ bwipe!
endfunc
" Test for the 'shellquote' option
diff --git a/src/version.c b/src/version.c
index c76d312..83feed9 100644
--- a/src/version.c
+++ b/src/version.c
@@ -739,6 +739,8 @@
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 403,
+/**/
402,
/**/
401,