commit a29856fcdc41541c607437629c1c1f45951100a4
author Bram Moolenaar <Bram@vim.org> Mon Sep 13 21:36:27 2021 +0200
committer Bram Moolenaar <Bram@vim.org> Mon Sep 13 21:36:27 2021 +0200
tree ff06dca350f51b3f8c70a947eeb4e5e7ad0accc3
parent b1b6f4de2b0edc3b6622912132ddb8994ec52709

patch 8.2.3436: check for optional bool type has confusing return type

Problem:    Check for optional bool type has confusing return type.
Solution:   Explicitly return OK.

src/typval.c

diff --git a/src/typval.c b/src/typval.c
index 5fb98eb..3a0e2e5 100644
--- a/src/typval.c
+++ b/src/typval.c
@@ -459,13 +459,15 @@
 }
 
 /*
- * Check for an optional bool argument at 'idx'
+ * Check for an optional bool argument at 'idx'.
+ * Return FAIL if the type is wrong.
  */
     int
 check_for_opt_bool_arg(typval_T *args, int idx)
 {
-    return (args[idx].v_type == VAR_UNKNOWN
-	    || check_for_bool_arg(args, idx) != FAIL);
+    if (args[idx].v_type == VAR_UNKNOWN)
+	return OK;
+    return check_for_bool_arg(args, idx);
 }
 
 /*

src/version.c

diff --git a/src/version.c b/src/version.c
index 8973e48..6fd967c 100644
--- a/src/version.c
+++ b/src/version.c
@@ -756,6 +756,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    3436,
+/**/
     3435,
 /**/
     3434,