commit a15ef4588c057da87f64be5b17aef35aaead8ac8
author Bram Moolenaar <Bram@vim.org> Fri Feb 09 16:46:00 2018 +0100
committer Bram Moolenaar <Bram@vim.org> Fri Feb 09 16:46:00 2018 +0100
tree ab7a31aa6eddca5f18a66db878a4a1075450379e
parent 9d32276b52a63fccfae681f0d1d6ccb66efec1c0

patch 8.0.1484: reduntant conditions

Problem:    Reduntant conditions.
Solution:   Remove them. (Dominique Pelle)

src/terminal.c

diff --git a/src/terminal.c b/src/terminal.c
index 56c250b..02d0715 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -523,7 +523,7 @@
     init_job_options(&opt);
 
     cmd = eap->arg;
-    while (*cmd && *cmd == '+' && *(cmd + 1) == '+')
+    while (*cmd == '+' && *(cmd + 1) == '+')
     {
 	char_u  *p, *ep;
 
@@ -3259,8 +3259,7 @@
 	return;
 
     /* Get the job status, this will detect a job that finished. */
-    if ((buf->b_term->tl_job->jv_channel == NULL
-			     || !buf->b_term->tl_job->jv_channel->ch_keep_open)
+    if (!buf->b_term->tl_job->jv_channel->ch_keep_open
 	    && STRCMP(job_status(buf->b_term->tl_job), "dead") == 0)
     {
 	/* The job is dead, keep reading channel I/O until the channel is