patch 9.0.2156: Vim9: can use typealias in assignment
Problem: Vim9: can use typealias in an assignment
Solution: Generate errors when class/typealias involved in the rhs of an
assignment
closes: #13637
Signed-off-by: Ernie Rael <errael@raelity.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
Generate errors when class/typealias involved in assignment.
diff --git a/src/testdir/test_vim9_class.vim b/src/testdir/test_vim9_class.vim
index 96d3ae5..84ea1cb 100644
--- a/src/testdir/test_vim9_class.vim
+++ b/src/testdir/test_vim9_class.vim
@@ -3093,25 +3093,77 @@
v9.CheckSourceSuccess(lines)
enddef
-def Test_call_constructor_from_legacy()
+def Test_construct_object_from_legacy()
+ # Cannot directly invoke constructor from legacy
var lines =<< trim END
vim9script
- var newCalled = 'false'
+ var newCalled = false
class A
- def new()
- newCalled = 'true'
+ def new(arg: string)
+ newCalled = true
enddef
endclass
- export def F(options = {}): any
- return A
+ export def CreateA(...args: list<any>): A
+ return call(A.new, args)
enddef
- g:p = F()
- legacy call p.new()
- assert_equal('true', newCalled)
+ g:P = CreateA
+ legacy call g:P('some_arg')
+ assert_equal(true, newCalled)
+ unlet g:P
+ END
+ v9.CheckSourceSuccess(lines)
+
+ lines =<< trim END
+ vim9script
+
+ var newCalled = false
+
+ class A
+ static def CreateA(options = {}): any
+ return A.new()
+ enddef
+ def new()
+ newCalled = true
+ enddef
+ endclass
+
+ g:P = A.CreateA
+ legacy call g:P()
+ assert_equal(true, newCalled)
+ unlet g:P
+ END
+ v9.CheckSourceSuccess(lines)
+
+ # This also tests invoking "new()" with "call"
+ lines =<< trim END
+ vim9script
+
+ var createdObject: any
+
+ class A
+ this.val1: number
+ this.val2: number
+ static def CreateA(...args: list<any>): any
+ createdObject = call(A.new, args)
+ return createdObject
+ enddef
+ endclass
+
+ g:P = A.CreateA
+ legacy call g:P(3, 5)
+ assert_equal(3, createdObject.val1)
+ assert_equal(5, createdObject.val2)
+ legacy call g:P()
+ assert_equal(0, createdObject.val1)
+ assert_equal(0, createdObject.val2)
+ legacy call g:P(7)
+ assert_equal(7, createdObject.val1)
+ assert_equal(0, createdObject.val2)
+ unlet g:P
END
v9.CheckSourceSuccess(lines)
enddef