commit 9b02d64cff7664b9643205d6e23b08da688fe87a
author Bram Moolenaar <Bram@vim.org> Tue Aug 18 23:24:13 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Tue Aug 18 23:24:13 2020 +0200
tree 804dcf431045364147355ac16b2cde1be7e75773
parent 165036ddba1318576a29f75d82fae8c326a48f18

patch 8.2.1484: flaky failure in assert_fails()

Problem:    Flaky failure in assert_fails().
Solution:   Only used fourth argument if there is a third argument.

src/testing.c

diff --git a/src/testing.c b/src/testing.c
index 0971876..ed2d511 100644
--- a/src/testing.c
+++ b/src/testing.c
@@ -615,7 +615,8 @@
 	    goto theend;
 	}
 
-	if (!error_found && argvars[3].v_type == VAR_NUMBER
+	if (!error_found && argvars[2].v_type != VAR_UNKNOWN
+		&& argvars[3].v_type == VAR_NUMBER
 		&& argvars[3].vval.v_number >= 0
 		&& argvars[3].vval.v_number != emsg_assert_fails_lnum)
 	{