patch 8.2.3954: Vim9: no error for shadowing if script var is declared later
Problem: Vim9: no error for shadowing if script var is declared later.
Solution: Check argument names when compiling a function.
diff --git a/src/testdir/test_vim9_assign.vim b/src/testdir/test_vim9_assign.vim
index f02da7f..6831809 100644
--- a/src/testdir/test_vim9_assign.vim
+++ b/src/testdir/test_vim9_assign.vim
@@ -853,8 +853,8 @@
var nres: any
var sres: any
- def Func(n: number, s = '')
- nres = n
+ def Func(nr: number, s = '')
+ nres = nr
sres = s
enddef
@@ -869,7 +869,7 @@
lines =<< trim END
vim9script
- def Func(n: number, s = '')
+ def Func(nr: number, s = '')
enddef
var n: number
diff --git a/src/testdir/test_vim9_func.vim b/src/testdir/test_vim9_func.vim
index 7b2f501..1cdf7d4 100644
--- a/src/testdir/test_vim9_func.vim
+++ b/src/testdir/test_vim9_func.vim
@@ -951,6 +951,7 @@
END
CheckScriptFailure(lines, 'E1013: Argument 1: type mismatch, expected string but got list<unknown>', 5)
+ # argument name declared earlier is found when declaring a function
lines =<< trim END
vim9script
var name = 'piet'
@@ -960,6 +961,17 @@
END
CheckScriptFailure(lines, 'E1168:')
+ # argument name declared later is only found when compiling
+ lines =<< trim END
+ vim9script
+ def FuncOne(name: string)
+ echo nr
+ enddef
+ var name = 'piet'
+ END
+ CheckScriptSuccess(lines)
+ CheckScriptFailure(lines + ['defcompile'], 'E1168:')
+
lines =<< trim END
vim9script
def FuncOne(nr: number)