patch 9.0.0361: removing a listener may result in a memory leak
Problem: Removing a listener may result in a memory leak and remove
subsequent listerns.
Solution: Init the "prev" pointer only once. (Yegappan Lakshmanan,
closes #11039)
diff --git a/src/change.c b/src/change.c
index 71ad9ea..b84dfad 100644
--- a/src/change.c
+++ b/src/change.c
@@ -362,6 +362,7 @@
int save_updating_screen = updating_screen;
static int recursive = FALSE;
listener_T *next;
+ listener_T *prev;
if (buf->b_recorded_changes == NULL // nothing changed
|| buf->b_listener == NULL // no listeners
@@ -406,10 +407,9 @@
}
// If f_listener_remove() was called may have to remove a listener now.
+ prev = NULL;
for (lnr = buf->b_listener; lnr != NULL; lnr = next)
{
- listener_T *prev = NULL;
-
next = lnr->lr_next;
if (lnr->lr_id == 0)
remove_listener(buf, lnr, prev);