commit 90fba5627b361dbc970b3afc2eebf7411c49a0cc
author Bram Moolenaar <Bram@vim.org> Fri Jul 09 19:17:55 2021 +0200
committer Bram Moolenaar <Bram@vim.org> Fri Jul 09 19:17:55 2021 +0200
tree 3565391643590c32c85281582cba9b3a0d361c5a
parent 6bcb18253a392cf75d3784953ef9c71de7af9019

patch 8.2.3133: Vim9: memory leak when add() fails

Problem:    Vim9: memory leak when add() fails.
Solution:   Allocate listitem_T after type check.

src/list.c

diff --git a/src/list.c b/src/list.c
index 9aec823..d138d86 100644
--- a/src/list.c
+++ b/src/list.c
@@ -602,11 +602,12 @@
     int
 list_append_tv(list_T *l, typval_T *tv)
 {
-    listitem_T	*li = listitem_alloc();
+    listitem_T	*li;
 
     if (l->lv_type != NULL && l->lv_type->tt_member != NULL
 		&& check_typval_arg_type(l->lv_type->tt_member, tv, 0) == FAIL)
 	return FAIL;
+    li = listitem_alloc();
     if (li == NULL)
 	return FAIL;
     copy_tv(tv, &li->li_tv);