patch 8.2.4625: old Coverity warning for resource leak
Problem: Old Coverity warning for resource leak.
Solution: Call FreeWild() if expanding matches did not fail.
diff --git a/src/help.c b/src/help.c
index 661d5b5..48178fd 100644
--- a/src/help.c
+++ b/src/help.c
@@ -947,6 +947,7 @@
FILE *fd_tags;
FILE *fd;
garray_T ga;
+ int res;
int filecount;
char_u **files;
char_u *p1, *p2;
@@ -965,12 +966,14 @@
STRCPY(NameBuff, dir);
STRCAT(NameBuff, "/**/*");
STRCAT(NameBuff, ext);
- if (gen_expand_wildcards(1, &NameBuff, &filecount, &files,
- EW_FILE|EW_SILENT) == FAIL
- || filecount == 0)
+ res = gen_expand_wildcards(1, &NameBuff, &filecount, &files,
+ EW_FILE|EW_SILENT);
+ if (res == FAIL || filecount == 0)
{
if (!got_int)
semsg(_(e_no_match_str_1), NameBuff);
+ if (res != FAIL)
+ FreeWild(filecount, files);
return;
}