commit 8e9a24a127c4ef8833fdc3986623f96c7d04210f
author Bram Moolenaar <Bram@vim.org> Tue Mar 19 22:22:55 2019 +0100
committer Bram Moolenaar <Bram@vim.org> Tue Mar 19 22:22:55 2019 +0100
tree d1aee2626ace3749ccbac2766ee158037b43bf2a
parent 828bff1f9b4847da79abd7a97ddc48687e257d6c

patch 8.1.1021: pyeval() and py3eval() leak memory

Problem:    pyeval() and py3eval() leak memory.
Solution:   Do not increase the reference count twice. (Ozaki Kiichi,
            closes #4129)

src/if_python.c

diff --git a/src/if_python.c b/src/if_python.c
index c0a3fe1..9f9c257 100644
--- a/src/if_python.c
+++ b/src/if_python.c
@@ -1555,30 +1555,16 @@
 }
 
     void
-do_pyeval (char_u *str, typval_T *rettv)
+do_pyeval(char_u *str, typval_T *rettv)
 {
     DoPyCommand((char *) str,
 	    (rangeinitializer) init_range_eval,
 	    (runner) run_eval,
 	    (void *) rettv);
-    switch (rettv->v_type)
+    if (rettv->v_type == VAR_UNKNOWN)
     {
-	case VAR_DICT: ++rettv->vval.v_dict->dv_refcount; break;
-	case VAR_LIST: ++rettv->vval.v_list->lv_refcount; break;
-	case VAR_FUNC: func_ref(rettv->vval.v_string);    break;
-	case VAR_PARTIAL: ++rettv->vval.v_partial->pt_refcount; break;
-	case VAR_UNKNOWN:
-	    rettv->v_type = VAR_NUMBER;
-	    rettv->vval.v_number = 0;
-	    break;
-	case VAR_NUMBER:
-	case VAR_STRING:
-	case VAR_FLOAT:
-	case VAR_SPECIAL:
-	case VAR_JOB:
-	case VAR_CHANNEL:
-	case VAR_BLOB:
-	    break;
+	rettv->v_type = VAR_NUMBER;
+	rettv->vval.v_number = 0;
     }
 }
 
@@ -1594,7 +1580,7 @@
 #endif /* Python 1.4 */
 
     int
-set_ref_in_python (int copyID)
+set_ref_in_python(int copyID)
 {
     return set_ref_in_py(copyID);
 }