patch 8.2.0510: Coverity complains about using uninitialized variable
Problem: Coverity complains about using uninitialized variable.
Solution: Assign a value to "scol". Move code inside NULL check.
diff --git a/src/popupwin.c b/src/popupwin.c
index 3a0dcb9..608db4c 100644
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -798,16 +798,16 @@
if (*str != NUL)
wp->w_border_char[i] = mb_ptr2char(str);
}
- }
- if (list->lv_len == 1)
- for (i = 1; i < 8; ++i)
- wp->w_border_char[i] = wp->w_border_char[0];
- if (list->lv_len == 2)
- {
- for (i = 4; i < 8; ++i)
- wp->w_border_char[i] = wp->w_border_char[1];
- for (i = 1; i < 4; ++i)
- wp->w_border_char[i] = wp->w_border_char[0];
+ if (list->lv_len == 1)
+ for (i = 1; i < 8; ++i)
+ wp->w_border_char[i] = wp->w_border_char[0];
+ if (list->lv_len == 2)
+ {
+ for (i = 4; i < 8; ++i)
+ wp->w_border_char[i] = wp->w_border_char[1];
+ for (i = 1; i < 4; ++i)
+ wp->w_border_char[i] = wp->w_border_char[0];
+ }
}
}
}