commit 8d4ed11da635a1abe0ef2d795b4d48824c54d0e7
author Bram Moolenaar <Bram@vim.org> Sat Apr 04 14:50:32 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Sat Apr 04 14:50:32 2020 +0200
tree 2e6e32cb89174e28967a9cd9a9408c99c884a609
parent cde0ff39da2459b16007fef701ebaa449fb6fe9d

patch 8.2.0510: Coverity complains about using uninitialized variable

Problem:    Coverity complains about using uninitialized variable.
Solution:   Assign a value to "scol".  Move code inside NULL check.

src/beval.c

diff --git a/src/beval.c b/src/beval.c
index 63aaf13..6b10a65 100644
--- a/src/beval.c
+++ b/src/beval.c
@@ -110,6 +110,8 @@
 			lbuf = vim_strnsave(lbuf, len);
 		    }
 		}
+		else
+		    scol = col;
 
 		if (winp != NULL)
 		    *winp = wp;

src/popupwin.c

diff --git a/src/popupwin.c b/src/popupwin.c
index 3a0dcb9..608db4c 100644
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -798,16 +798,16 @@
 		    if (*str != NUL)
 			wp->w_border_char[i] = mb_ptr2char(str);
 		}
-	    }
-	    if (list->lv_len == 1)
-		for (i = 1; i < 8; ++i)
-		    wp->w_border_char[i] = wp->w_border_char[0];
-	    if (list->lv_len == 2)
-	    {
-		for (i = 4; i < 8; ++i)
-		    wp->w_border_char[i] = wp->w_border_char[1];
-		for (i = 1; i < 4; ++i)
-		    wp->w_border_char[i] = wp->w_border_char[0];
+		if (list->lv_len == 1)
+		    for (i = 1; i < 8; ++i)
+			wp->w_border_char[i] = wp->w_border_char[0];
+		if (list->lv_len == 2)
+		{
+		    for (i = 4; i < 8; ++i)
+			wp->w_border_char[i] = wp->w_border_char[1];
+		    for (i = 1; i < 4; ++i)
+			wp->w_border_char[i] = wp->w_border_char[0];
+		}
 	    }
 	}
     }

src/version.c

diff --git a/src/version.c b/src/version.c
index 34553c6..122dcc8 100644
--- a/src/version.c
+++ b/src/version.c
@@ -739,6 +739,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    510,
+/**/
     509,
 /**/
     508,