| commit | 8950bf7f8b85c1287d4e696965d88091fcc60594 | [log] [tgz] |
|---|---|---|
| author | Girish Palya <girishji@gmail.com> | Wed Mar 20 20:07:29 2024 +0100 |
| committer | Christian Brabandt <cb@256bit.org> | Wed Mar 20 20:11:26 2024 +0100 |
| tree | 07a2e5322cb8f79c2e07ecfbac86807b504ca652 | |
| parent | 2708c0b5854faad2844454324431a593c1d2987a [diff] [blame] |
patch 9.1.0190: complete_info() returns wrong order of items
Problem: complete_info() returns wrong order of items
(after v9.0.2018)
Solution: Revert Patch v9.0.2018
(Girish Palya)
bug fix: complete_info() gives wrong results
1) complete_info() reverses list of items during <c-p>
2) 'selected' item index is wrong during <c-p>
3) number of items returnd can be wrong
Solution:
- Decouple 'cp_number' from 'selected' index since they need not be
correlated
- Do not iterate the list backwards
- Add targeted tests
Regression introduced by https://github.com/vim/vim/commit/69fb5afb3bc9da24c2fb0eafb0027ba9c6502fc2
Following are unnecessary commits to patch problems from above:
https://github.com/vim/vim/commit/fef66301665027f1801a18d796f74584666f41ef
https://github.com/vim/vim/commit/daef8c74375141974d61b85199b383017644978c
All the tests from above commits are retained though.
fixes: #14204
closes: #14241
Signed-off-by: Girish Palya <girishji@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
diff --git a/src/version.c b/src/version.c index 3affeff..2963827 100644 --- a/src/version.c +++ b/src/version.c
@@ -705,6 +705,8 @@ static int included_patches[] = { /* Add new patch number below this line */ /**/ + 190, +/**/ 189, /**/ 188,