commit 892ae723ab95e429222e930cf41b32809567e58e
author Bram Moolenaar <Bram@vim.org> Sun Jun 30 20:33:01 2019 +0200
committer Bram Moolenaar <Bram@vim.org> Sun Jun 30 20:33:01 2019 +0200
tree b13676187124dfbde65761e13bb9791d4ede5775
parent 15e248e37f3925d430f96e945d52d3dc423cdc83

patch 8.1.1611: bufadd() reuses existing buffer without a name

Problem:    Bufadd() reuses existing buffer without a name.
Solution:   When the name is empty always create a new buffer.

src/evalfunc.c

diff --git a/src/evalfunc.c b/src/evalfunc.c
index 954ea9f..01afa3d 100644
--- a/src/evalfunc.c
+++ b/src/evalfunc.c
@@ -1929,7 +1929,9 @@
     static void
 f_bufadd(typval_T *argvars, typval_T *rettv)
 {
-    rettv->vval.v_number = buflist_add(tv_get_string(&argvars[0]), 0);
+    char_u *name = tv_get_string(&argvars[0]);
+
+    rettv->vval.v_number = buflist_add(*name == NUL ? NULL : name, 0);
 }
 
 /*

src/testdir/test_functions.vim

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index 34a4bbf..a08cef7 100644
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -1539,6 +1539,20 @@
   call assert_equal(['some', 'text'], getbufline(buf, 1, '$'))
   call assert_equal(curbuf, bufnr(''))
 
+  let buf1 = bufadd('')
+  let buf2 = bufadd('')
+  call assert_notequal(0, buf1)
+  call assert_notequal(0, buf2)
+  call assert_notequal(buf1, buf2)
+  call assert_equal(1, bufexists(buf1))
+  call assert_equal(1, bufexists(buf2))
+  call assert_equal(0, bufloaded(buf1))
+  exe 'bwipe ' .. buf1
+  call assert_equal(0, bufexists(buf1))
+  call assert_equal(1, bufexists(buf2))
+  exe 'bwipe ' .. buf2
+  call assert_equal(0, bufexists(buf2))
+
   bwipe someName
   bwipe otherName
   call assert_equal(0, bufexists('someName'))

src/version.c

diff --git a/src/version.c b/src/version.c
index 6fce98b..a1c5f88 100644
--- a/src/version.c
+++ b/src/version.c
@@ -778,6 +778,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1611,
+/**/
     1610,
 /**/
     1609,