patch 9.0.1597: cursor ends up below the window after a put
Problem: Cursor ends up below the window after a put.
Solution: Mark w_crow and w_botline invalid when changing the cursor line.
(closes #12465)
diff --git a/src/eval.c b/src/eval.c
index b8d954d..89141bf 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -6322,6 +6322,10 @@
if (name[0] == 'w' && dollar_lnum)
{
+ // the "w_valid" flags are not reset when moving the cursor, but they
+ // do matter for update_topline() and validate_botline().
+ check_cursor_moved(curwin);
+
pos.col = 0;
if (name[1] == '0') // "w0": first visible line
{
diff --git a/src/move.c b/src/move.c
index e435bb0..a113919 100644
--- a/src/move.c
+++ b/src/move.c
@@ -715,19 +715,21 @@
/*
* Call this function when the length of the cursor line (in screen
* characters) has changed, and the change is before the cursor.
+ * If the line length changed the number of screen lines might change,
+ * requiring updating w_topline. That may also invalidate w_crow.
* Need to take care of w_botline separately!
*/
void
changed_cline_bef_curs(void)
{
- curwin->w_valid &= ~(VALID_WROW|VALID_WCOL|VALID_VIRTCOL
+ curwin->w_valid &= ~(VALID_WROW|VALID_WCOL|VALID_VIRTCOL|VALID_CROW
|VALID_CHEIGHT|VALID_TOPLINE);
}
void
changed_cline_bef_curs_win(win_T *wp)
{
- wp->w_valid &= ~(VALID_WROW|VALID_WCOL|VALID_VIRTCOL
+ wp->w_valid &= ~(VALID_WROW|VALID_WCOL|VALID_VIRTCOL|VALID_CROW
|VALID_CHEIGHT|VALID_TOPLINE);
}
diff --git a/src/register.c b/src/register.c
index e481d84..9a23be8 100644
--- a/src/register.c
+++ b/src/register.c
@@ -2098,6 +2098,7 @@
{
// make sure curwin->w_virtcol is updated
changed_cline_bef_curs();
+ invalidate_botline();
curwin->w_cursor.col += (colnr_T)(totlen - 1);
}
if (VIsual_active)
diff --git a/src/testdir/dumps/Test_put_in_last_displayed_line_1.dump b/src/testdir/dumps/Test_put_in_last_displayed_line_1.dump
new file mode 100644
index 0000000..3d094f5
--- /dev/null
+++ b/src/testdir/dumps/Test_put_in_last_displayed_line_1.dump
@@ -0,0 +1,10 @@
+|2+0&#ffffff0| @73
+|3| @73
+|4| @73
+|5| @73
+|6| @73
+|7| @73
+|8| @73
+|9|x@73
+@73>x|
+@57|1|0|,|1|4|9| @7|B|o|t|
diff --git a/src/testdir/test_put.vim b/src/testdir/test_put.vim
index 4b514bb..72479ac 100644
--- a/src/testdir/test_put.vim
+++ b/src/testdir/test_put.vim
Binary files differ
diff --git a/src/version.c b/src/version.c
index 132a0d9..11b962d 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 1597,
+/**/
1596,
/**/
1595,