patch 8.2.3560: using freed memory with lambda
Problem: Using freed memory with lambda.
Solution: Do not free lines early, keep them until the expression is
finished.
diff --git a/src/eval.c b/src/eval.c
index aceba5e..41291a2 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -143,7 +143,7 @@
void
fill_evalarg_from_eap(evalarg_T *evalarg, exarg_T *eap, int skip)
{
- CLEAR_FIELD(*evalarg);
+ init_evalarg(evalarg);
evalarg->eval_flags = skip ? 0 : EVAL_EVALUATE;
if (eap != NULL)
{
@@ -2137,8 +2137,7 @@
// Advanced to the next line, "arg" no longer points into the previous
// line.
- VIM_CLEAR(evalarg->eval_tofree_cmdline);
-
+ evalarg->eval_using_cmdline = FALSE;
return skipwhite(line);
}
@@ -2160,6 +2159,16 @@
}
/*
+ * Initialize "evalarg" for use.
+ */
+ void
+init_evalarg(evalarg_T *evalarg)
+{
+ CLEAR_POINTER(evalarg);
+ ga_init2(&evalarg->eval_tofree_ga, sizeof(char_u *), 20);
+}
+
+/*
* After using "evalarg" filled from "eap": free the memory.
*/
void
@@ -2183,7 +2192,7 @@
evalarg->eval_tofree = NULL;
}
- VIM_CLEAR(evalarg->eval_tofree_cmdline);
+ ga_clear_strings(&evalarg->eval_tofree_ga);
VIM_CLEAR(evalarg->eval_tofree_lambda);
}
}
@@ -2298,7 +2307,7 @@
if (evalarg == NULL)
{
- CLEAR_FIELD(local_evalarg);
+ init_evalarg(&local_evalarg);
evalarg_used = &local_evalarg;
}
orig_flags = evalarg_used->eval_flags;
@@ -2455,7 +2464,7 @@
if (evalarg == NULL)
{
- CLEAR_FIELD(local_evalarg);
+ init_evalarg(&local_evalarg);
evalarg_used = &local_evalarg;
}
orig_flags = evalarg_used->eval_flags;
@@ -2581,7 +2590,7 @@
if (evalarg == NULL)
{
- CLEAR_FIELD(local_evalarg);
+ init_evalarg(&local_evalarg);
evalarg_used = &local_evalarg;
}
orig_flags = evalarg_used->eval_flags;