commit 7ba3b91e0385c848c773e2f2d803db01730e7786
author Bram Moolenaar <Bram@vim.org> Mon Feb 10 20:34:04 2020 +0100
committer Bram Moolenaar <Bram@vim.org> Mon Feb 10 20:34:04 2020 +0100
tree ba8120ac6c9dbbbc973d5206de5d47df9b43044f
parent 57ea2924e5dd14aac716a1ee349bdb61f6429f59

patch 8.2.0237: crash when setting 'wincolor' on finished terminal window

Problem:    Crash when setting 'wincolor' on finished terminal window.
            (Bakudankun)
Solution:   Check that the vterm is not NULL. (Yasuhiro Matsumoto, closes
            #5607, closes #5610)

src/terminal.c

diff --git a/src/terminal.c b/src/terminal.c
index cbf8fe0..10bfae8 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -4276,6 +4276,8 @@
 {
     term_T *term = curwin->w_buffer->b_term;
 
+    if (term->tl_vterm == NULL)
+	return;
     init_default_colors(term, curwin);
     vterm_state_set_default_colors(
 	    vterm_obtain_state(term->tl_vterm),

src/testdir/test_terminal.vim

diff --git a/src/testdir/test_terminal.vim b/src/testdir/test_terminal.vim
index 0963405..8c1d357 100644
--- a/src/testdir/test_terminal.vim
+++ b/src/testdir/test_terminal.vim
@@ -2370,3 +2370,18 @@
   call StopVimInTerminal(buf)
   call delete('XtermPopup')
 endfunc
+
+func Test_issue_5607()
+  let wincount = winnr('$')
+  exe 'terminal' &shell &shellcmdflag 'exit'
+  let job = term_getjob(bufnr())
+  call WaitForAssert({-> assert_equal("dead", job_status(job))})
+
+  let old_wincolor = &wincolor
+  try
+    set wincolor=
+  finally
+    let &wincolor = old_wincolor
+    bw!
+  endtry
+endfunc

src/version.c

diff --git a/src/version.c b/src/version.c
index 7ca6baa..7c48e0b 100644
--- a/src/version.c
+++ b/src/version.c
@@ -743,6 +743,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    237,
+/**/
     236,
 /**/
     235,