commit 7a2d9892b7158edf8dc48e9bcaaae70a40787b37
author Bram Moolenaar <Bram@vim.org> Mon Dec 24 20:23:49 2018 +0100
committer Bram Moolenaar <Bram@vim.org> Mon Dec 24 20:23:49 2018 +0100
tree e448e08f0ac96c806d96209f9c1bd415101e5175
parent d6024e2dd4e0c1556d9b69e61c4059fa78e5609d

patch 8.1.0632: using sign group names is inefficient

Problem:    Using sign group names is inefficient.
Solution:   Store group names in a hash table and use a reference to them.
            Also remove unnecessary use of ":exe" from the tests.  (Yegappan
            Lakshmanan, closes #3715)

src/ex_cmds.c

diff --git a/src/ex_cmds.c b/src/ex_cmds.c
index 06df5af..52b669a 100644
--- a/src/ex_cmds.c
+++ b/src/ex_cmds.c
@@ -8180,7 +8180,7 @@
 	{
 	    EMSG2(_("E158: Invalid buffer name: %s"), arg);
 	}
-	else if (id <= 0 && !(idx == SIGNCMD_UNPLACE && id == -2))
+	else if (id <= 0 && idx == SIGNCMD_PLACE)
 	{
 	    if ((group == NULL) && (lnum >= 0 || sign_name != NULL))
 		EMSG(_(e_invarg));