patch 9.1.0436: Crash when using '?' as separator for :s
Problem: Crash when using '?' as separator for :s and pattern contains
escaped '?'s (after 9.1.0409).
Solution: Always compute startplen. (zeertzjq).
related: neovim/neovim#28935
closes: 14832
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
diff --git a/src/regexp.c b/src/regexp.c
index d431932..147452a 100644
--- a/src/regexp.c
+++ b/src/regexp.c
@@ -620,6 +620,7 @@
{
magic_T mymagic;
char_u *p = startp;
+ size_t startplen = STRLEN(startp);
if (magic)
mymagic = MAGIC_ON;
@@ -642,12 +643,9 @@
{
if (dirc == '?' && newp != NULL && p[1] == '?')
{
- size_t startplen = 0;
-
// change "\?" to "?", make a copy first.
if (*newp == NULL)
{
- startplen = STRLEN(startp);
*newp = vim_strnsave(startp, startplen);
if (*newp != NULL)
p = *newp + (p - startp);