patch 8.1.0572: stopping a job does not work properly on OpenBSD
Problem: Stopping a job does not work properly on OpenBSD.
Solution: Do not use getpgid() to check the process group of the job
processs ID, always pass the negative process ID to kill().
(George Koehler, closes #3656)
diff --git a/src/os_unix.c b/src/os_unix.c
index 4d902d9..ecb348c 100644
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -5820,7 +5820,6 @@
mch_signal_job(job_T *job, char_u *how)
{
int sig = -1;
- pid_t job_pid;
if (*how == NUL || STRCMP(how, "term") == 0)
sig = SIGTERM;
@@ -5841,16 +5840,13 @@
else
return FAIL;
- /* TODO: have an option to only kill the process, not the group? */
- job_pid = job->jv_pid;
-#ifdef HAVE_GETPGID
- if (job_pid == getpgid(job_pid))
- job_pid = -job_pid;
-#endif
-
- /* Never kill ourselves! */
- if (job_pid != 0)
- kill(job_pid, sig);
+ // Never kill ourselves!
+ if (job->jv_pid != 0)
+ {
+ // TODO: have an option to only kill the process, not the group?
+ kill(-job->jv_pid, sig);
+ kill(job->jv_pid, sig);
+ }
return OK;
}