commit 767034c5b82ba8999d9fed2f997436e6e3e99419
author Bram Moolenaar <Bram@vim.org> Fri Apr 09 17:24:52 2021 +0200
committer Bram Moolenaar <Bram@vim.org> Fri Apr 09 17:24:52 2021 +0200
tree b41c9572fc063a1bd77a6b2347d9148ef9955760
parent dcae51facc4d6de1edd62f0242b40972be841103

patch 8.2.2739: Vim9: a lambda accepts too many arguments at the script level

Problem:    Vim9: a lambda accepts too many arguments at the script level.
Solution:   Do not set uf_varargs in Vim9 script.

src/testdir/test_vim9_func.vim

diff --git a/src/testdir/test_vim9_func.vim b/src/testdir/test_vim9_func.vim
index 730cf40..b0669fe 100644
--- a/src/testdir/test_vim9_func.vim
+++ b/src/testdir/test_vim9_func.vim
@@ -836,6 +836,11 @@
       enddef
   END
   CheckDefFailure(lines, 'E1167:')
+
+  lines =<< trim END
+    echo ((a) => a)('aa', 'bb')
+  END
+  CheckDefAndScriptFailure(lines, 'E118:', 1)
 enddef
 
 def FilterWithCond(x: string, Cond: func(string): bool): bool
@@ -2114,7 +2119,7 @@
          ->substitute("('", ' ', '')
          ->substitute("')", '', '')
          ->substitute('function\zs', ' ', ''))
-  assert_match('def <lambda>\d\+(_: any, ...): number\n1  return 0\n   enddef', body)
+  assert_match('def <lambda>\d\+(_: any): number\n1  return 0\n   enddef', body)
 enddef
 
 def DoFilterThis(a: string): list<string>
@@ -2363,7 +2368,7 @@
       vim9script
       au BufWinLeave * #
       def Func()
-          popup_menu('', {callback: () => popup_create('', {})->popup_close()})
+          popup_menu('', {callback: (a, b) => popup_create('', {})->popup_close()})
           eval [][0]
       enddef
       nno <F3> <cmd>call <sid>Func()<cr>

src/testdir/test_vim9_script.vim

diff --git a/src/testdir/test_vim9_script.vim b/src/testdir/test_vim9_script.vim
index cb1592a..98f40bb 100644
--- a/src/testdir/test_vim9_script.vim
+++ b/src/testdir/test_vim9_script.vim
@@ -3518,7 +3518,7 @@
       vim9script
       set cpo+=M
       exe 'set rtp^=' .. getcwd() .. '/Xdir'
-      au CmdlineEnter : ++once timer_start(0, () => script#func())
+      au CmdlineEnter : ++once timer_start(0, (_) => script#func())
       setline(1, 'some text')
   END
   call writefile(lines, 'XTest_redraw_cpo')

src/userfunc.c

diff --git a/src/userfunc.c b/src/userfunc.c
index af107b0..81a73e2 100644
--- a/src/userfunc.c
+++ b/src/userfunc.c
@@ -1263,8 +1263,9 @@
 #endif
 	if (sandbox)
 	    flags |= FC_SANDBOX;
-	// can be called with more args than uf_args.ga_len
-	fp->uf_varargs = TRUE;
+	// In legacy script a lambda can be called with more args than
+	// uf_args.ga_len.
+	fp->uf_varargs = !in_vim9script();
 	fp->uf_flags = flags;
 	fp->uf_calls = 0;
 	fp->uf_script_ctx = current_sctx;

src/version.c

diff --git a/src/version.c b/src/version.c
index 452565c..a2bd558 100644
--- a/src/version.c
+++ b/src/version.c
@@ -751,6 +751,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2739,
+/**/
     2738,
 /**/
     2737,