patch 8.1.1575: callbacks may be garbage collected
Problem: Callbacks may be garbage collected.
Solution: Set reference in callbacks. (Ozaki Kiichi, closes #4564)
diff --git a/src/testdir/test_listener.vim b/src/testdir/test_listener.vim
index a318d52..ed501c2 100644
--- a/src/testdir/test_listener.vim
+++ b/src/testdir/test_listener.vim
@@ -225,3 +225,20 @@
exe "buf " .. bufnr
bwipe!
endfunc
+
+func Test_listener_garbage_collect()
+ func MyListener(x, bufnr, start, end, added, changes)
+ " NOP
+ endfunc
+
+ new
+ let id = listener_add(function('MyListener', [{}]), bufnr(''))
+ call test_garbagecollect_now()
+ " must not crach caused by invalid memory access
+ normal ia
+ call assert_true(v:true)
+
+ call listener_remove(id)
+ delfunc MyListener
+ bwipe!
+endfunc
diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim
index 451f0b6..c332dca 100644
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -1467,3 +1467,19 @@
call popup_close(winid)
endfunc
+
+func Test_popupwin_garbage_collect()
+ func MyPopupFilter(x, winid, c)
+ " NOP
+ endfunc
+
+ let winid = popup_create('something', {'filter': function('MyPopupFilter', [{}])})
+ call test_garbagecollect_now()
+ redraw
+ " Must not crach caused by invalid memory access
+ call feedkeys('j', 'xt')
+ call assert_true(v:true)
+
+ call popup_close(winid)
+ delfunc MyPopupFilter
+endfunc
diff --git a/src/testdir/test_prompt_buffer.vim b/src/testdir/test_prompt_buffer.vim
index 58be50b..028f337 100644
--- a/src/testdir/test_prompt_buffer.vim
+++ b/src/testdir/test_prompt_buffer.vim
@@ -102,3 +102,24 @@
call StopVimInTerminal(buf)
call delete(scriptName)
endfunc
+
+func Test_prompt_garbage_collect()
+ func MyPromptCallback(x, text)
+ " NOP
+ endfunc
+ func MyPromptInterrupt(x)
+ " NOP
+ endfunc
+
+ new
+ set buftype=prompt
+ call prompt_setcallback(bufnr(''), function('MyPromptCallback', [{}]))
+ call prompt_setinterrupt(bufnr(''), function('MyPromptInterrupt', [{}]))
+ call test_garbagecollect_now()
+ " Must not crash
+ call feedkeys("\<CR>\<C-C>", 'xt')
+ call assert_true(v:true)
+
+ delfunc MyPromptCallback
+ bwipe!
+endfunc