patch 8.1.1054: not checking return value of ga_grow()
Problem: Not checking return value of ga_grow(). (Coverity)
Solution: Only append when ga_grow() returns OK.
diff --git a/src/if_lua.c b/src/if_lua.c
index 825e834..cfb2885 100644
--- a/src/if_lua.c
+++ b/src/if_lua.c
@@ -1144,9 +1144,9 @@
size_t i, l = 0;
const char *s = lua_tolstring(L, 2, &l);
- ga_grow(&b->bv_ga, l);
- for (i = 0; i < l; ++i)
- ga_append(&b->bv_ga, s[i]);
+ if (ga_grow(&b->bv_ga, l) == OK)
+ for (i = 0; i < l; ++i)
+ ga_append(&b->bv_ga, s[i]);
}
lua_settop(L, 1);
return 1;
@@ -1776,9 +1776,9 @@
size_t i, l = 0;
const char *s = lua_tolstring(L, 1, &l);
- ga_grow(&b->bv_ga, l);
- for (i = 0; i < l; ++i)
- ga_append(&b->bv_ga, s[i]);
+ if (ga_grow(&b->bv_ga, l) == OK)
+ for (i = 0; i < l; ++i)
+ ga_append(&b->bv_ga, s[i]);
}
}
return 1;