commit 69e44552c567ff25b363ba0790ad3d43fa0397a7
author Bram Moolenaar <Bram@vim.org> Sat Aug 22 22:37:20 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Sat Aug 22 22:37:20 2020 +0200
tree 061de28c194fbf25ef55c960377a033ed2080525
parent cd94277f72e29b740635da84bcd872c96e11bf67

patch 8.2.1512: failure after trinary expression fails

Problem:    Failure after trinary expression fails.
Solution:   Restore eval_flags. (Yasuhiro Matsumoto, closes #6776)

src/eval.c

diff --git a/src/eval.c b/src/eval.c
index 4b1e0f1..056ac76 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -2167,7 +2167,10 @@
 	evalarg_used->eval_flags = result ? orig_flags
 						 : orig_flags & ~EVAL_EVALUATE;
 	if (eval1(arg, rettv, evalarg_used) == FAIL)
+	{
+	    evalarg_used->eval_flags = orig_flags;
 	    return FAIL;
+	}
 
 	/*
 	 * Check for the ":".
@@ -2178,6 +2181,7 @@
 	    emsg(_(e_missing_colon));
 	    if (evaluate && result)
 		clear_tv(rettv);
+	    evalarg_used->eval_flags = orig_flags;
 	    return FAIL;
 	}
 	if (getnext)
@@ -2188,6 +2192,7 @@
 	    {
 		error_white_both(p, 1);
 		clear_tv(rettv);
+		evalarg_used->eval_flags = orig_flags;
 		return FAIL;
 	    }
 	    *arg = p;
@@ -2200,6 +2205,7 @@
 	{
 	    error_white_both(p, 1);
 	    clear_tv(rettv);
+	    evalarg_used->eval_flags = orig_flags;
 	    return FAIL;
 	}
 	*arg = skipwhite_and_linebreak(*arg + 1, evalarg_used);
@@ -2209,6 +2215,7 @@
 	{
 	    if (evaluate && result)
 		clear_tv(rettv);
+	    evalarg_used->eval_flags = orig_flags;
 	    return FAIL;
 	}
 	if (evaluate && !result)

src/testdir/test_vim9_expr.vim

diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim
index d9e823a..4ff0fd7 100644
--- a/src/testdir/test_vim9_expr.vim
+++ b/src/testdir/test_vim9_expr.vim
@@ -114,6 +114,27 @@
       let var = v:true ? 1 :2
   END
   CheckScriptFailure(lines, 'E1004:', 2)
+
+  # check after failure eval_flags is reset
+  lines =<< trim END
+      vim9script
+      try
+        call eval('0 ? 1: 2')
+      catch
+      endtry
+      assert_equal(v:true, eval(string(v:true)))
+  END
+  CheckScriptSuccess(lines)
+
+  lines =<< trim END
+      vim9script
+      try
+        call eval('0 ? 1 :2')
+      catch
+      endtry
+      assert_equal(v:true, eval(string(v:true)))
+  END
+  CheckScriptSuccess(lines)
 enddef
 
 func Test_expr1_fails()

src/testdir/test_vimscript.vim

diff --git a/src/testdir/test_vimscript.vim b/src/testdir/test_vimscript.vim
index 9dd5fc7..f17e908 100644
--- a/src/testdir/test_vimscript.vim
+++ b/src/testdir/test_vimscript.vim
@@ -7445,6 +7445,30 @@
   call StopVimInTerminal(buf)
 endfunc
 
+" Test for issue6776              {{{1
+func Test_trinary_expression()
+  try
+    call eval('0 ? 0')
+  catch
+  endtry
+  " previous failure should not cause next expression to fail
+  call assert_equal(v:false, eval(string(v:false)))
+
+  try
+    call eval('0 ? "burp')
+  catch
+  endtry
+  " previous failure should not cause next expression to fail
+  call assert_equal(v:false, eval(string(v:false)))
+
+  try
+    call eval('1 ? 0 : "burp')
+  catch
+  endtry
+  " previous failure should not cause next expression to fail
+  call assert_equal(v:false, eval(string(v:false)))
+endfunction
+
 "-------------------------------------------------------------------------------
 " Modelines								    {{{1
 " vim: ts=8 sw=2 sts=2 expandtab tw=80 fdm=marker

src/version.c

diff --git a/src/version.c b/src/version.c
index 6b4fc61..2b996d6 100644
--- a/src/version.c
+++ b/src/version.c
@@ -755,6 +755,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1512,
+/**/
     1511,
 /**/
     1510,