patch 8.2.3588: break statement is never reached
Problem: Break statement is never reached.
Solution: Rely on return value of set_chars_option() not changing.
(closes #9103)
diff --git a/src/optionstr.c b/src/optionstr.c
index 3afb3db..2c4b2b8 100644
--- a/src/optionstr.c
+++ b/src/optionstr.c
@@ -1331,11 +1331,10 @@
if (!(opt_flags & OPT_GLOBAL))
clear_string_option(&curwin->w_p_lcs);
FOR_ALL_TAB_WINDOWS(tp, wp)
- {
- errmsg = set_chars_option(wp, &wp->w_p_lcs);
- if (errmsg)
- break;
- }
+ // If no error was returned above, we don't expect an error
+ // here, so ignore the return value.
+ (void)set_chars_option(wp, &wp->w_p_lcs);
+
redraw_all_later(NOT_VALID);
}
}