patch 8.0.0666: dead for loop
Problem: Dead for loop. (Coverity)
Solution: Remove the for loop.
diff --git a/src/term.c b/src/term.c
index f36f093..56d698b 100644
--- a/src/term.c
+++ b/src/term.c
@@ -4601,59 +4601,54 @@
|| key_name[0] == KS_SGR_MOUSE
|| key_name[0] == KS_SGR_MOUSE_RELEASE)
{
- for (;;)
- {
- /* URXVT 1015 mouse reporting mode:
- * Almost identical to xterm mouse mode, except the values
- * are decimal instead of bytes.
- *
- * \033[%d;%d;%dM
- * ^-- row
- * ^----- column
- * ^-------- code
- *
- * SGR 1006 mouse reporting mode:
- * Almost identical to xterm mouse mode, except the values
- * are decimal instead of bytes.
- *
- * \033[<%d;%d;%dM
- * ^-- row
- * ^----- column
- * ^-------- code
- *
- * \033[<%d;%d;%dm : mouse release event
- * ^-- row
- * ^----- column
- * ^-------- code
- */
- p = modifiers_start;
- if (p == NULL)
- return -1;
+ /* URXVT 1015 mouse reporting mode:
+ * Almost identical to xterm mouse mode, except the values
+ * are decimal instead of bytes.
+ *
+ * \033[%d;%d;%dM
+ * ^-- row
+ * ^----- column
+ * ^-------- code
+ *
+ * SGR 1006 mouse reporting mode:
+ * Almost identical to xterm mouse mode, except the values
+ * are decimal instead of bytes.
+ *
+ * \033[<%d;%d;%dM
+ * ^-- row
+ * ^----- column
+ * ^-------- code
+ *
+ * \033[<%d;%d;%dm : mouse release event
+ * ^-- row
+ * ^----- column
+ * ^-------- code
+ */
+ p = modifiers_start;
+ if (p == NULL)
+ return -1;
- mouse_code = getdigits(&p);
- if (*p++ != ';')
- return -1;
+ mouse_code = getdigits(&p);
+ if (*p++ != ';')
+ return -1;
- /* when mouse reporting is SGR, add 32 to mouse code */
- if (key_name[0] == KS_SGR_MOUSE
- || key_name[0] == KS_SGR_MOUSE_RELEASE)
- mouse_code += 32;
+ /* when mouse reporting is SGR, add 32 to mouse code */
+ if (key_name[0] == KS_SGR_MOUSE
+ || key_name[0] == KS_SGR_MOUSE_RELEASE)
+ mouse_code += 32;
- if (key_name[0] == KS_SGR_MOUSE_RELEASE)
- mouse_code |= MOUSE_RELEASE;
+ if (key_name[0] == KS_SGR_MOUSE_RELEASE)
+ mouse_code |= MOUSE_RELEASE;
- mouse_col = getdigits(&p) - 1;
- if (*p++ != ';')
- return -1;
+ mouse_col = getdigits(&p) - 1;
+ if (*p++ != ';')
+ return -1;
- mouse_row = getdigits(&p) - 1;
+ mouse_row = getdigits(&p) - 1;
- /* The modifiers were the mouse coordinates, not the
- * modifier keys (alt/shift/ctrl/meta) state. */
- modifiers = 0;
-
- break;
- }
+ /* The modifiers were the mouse coordinates, not the
+ * modifier keys (alt/shift/ctrl/meta) state. */
+ modifiers = 0;
}
# endif