commit 5e9aaedf520e850470fdecebb1ceccba0956178e
author Yegappan Lakshmanan <yegappan@yahoo.com> Sat Jan 18 10:24:25 2025 +0100
committer Christian Brabandt <cb@256bit.org> Sat Jan 18 10:29:46 2025 +0100
tree 9c4abf6d358bbe573238435273d5df136d653632
parent 54cb514c9a8320d77650a63f0f7405aa8cc5b0d7

patch 9.1.1031: Coverity complains about insecure data handling

Problem:  Coverity complains about insecure data handling
          (v9.1.1024)
Solution: use int consistently to access the blob index
          (Yegappan Lakshmanan)

related: #16468

Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

src/fileio.c

diff --git a/src/fileio.c b/src/fileio.c
index 93e13e3..a2031e9 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -4308,7 +4308,7 @@
 	     */
 	    busy = TRUE;
 #ifdef FEAT_EVAL
-	    set_vim_var_string(VV_FCS_REASON, (char_u *)reason, reasonlen);
+	    set_vim_var_string(VV_FCS_REASON, (char_u *)reason, (int)reasonlen);
 	    set_vim_var_string(VV_FCS_CHOICE, (char_u *)"", 0);
 #endif
 	    ++allbuf_lock;

src/strings.c

diff --git a/src/strings.c b/src/strings.c
index a71ac91..53e0171 100644
--- a/src/strings.c
+++ b/src/strings.c
@@ -1265,7 +1265,7 @@
 {
     garray_T	str_ga;
     long	blen;
-    long	idx;
+    int		idx;
 
     ga_init2(&str_ga, sizeof(char), 80);
 

src/testdir/test_functions.vim

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index 5e0fd7d..bf3e889 100644
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -4282,6 +4282,9 @@
     call assert_equal(0zABBB0AABBB, str2blob(['«»', '«»'], {'encoding': 'latin1'}))
     call assert_equal(0zC2ABC2BB, str2blob(['«»'], {'encoding': 'utf8'}))
 
+    call assert_equal(0z62, str2blob(["b"], test_null_dict()))
+    call assert_equal(0z63, str2blob(["c"], {'encoding': test_null_string()}))
+
     call assert_fails("call str2blob(['abc'], [])", 'E1206: Dictionary required for argument 2')
     call assert_fails("call str2blob(['abc'], {'encoding': []})", 'E730: Using a List as a String')
     call assert_fails("call str2blob(['abc'], {'encoding': 'ab12xy'})", 'E1515: Unable to convert to ''ab12xy'' encoding')

src/version.c

diff --git a/src/version.c b/src/version.c
index 43a84e8..d273ce7 100644
--- a/src/version.c
+++ b/src/version.c
@@ -705,6 +705,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1031,
+/**/
     1030,
 /**/
     1029,