commit 58ceca5cae75ed839b20a89c5fa9998f02552f58
author Bram Moolenaar <Bram@vim.org> Tue Jan 28 22:46:22 2020 +0100
committer Bram Moolenaar <Bram@vim.org> Tue Jan 28 22:46:22 2020 +0100
tree 4b567ea57901fcb1fe3bf95c5332dc049f02fdbc
parent 07da94b0f07beb15c7e26b78837def5a91e102dc

patch 8.2.0167: Coverity warning for ignoring return value

Problem:    Coverity warning for ignoring return value.
Solution:   Check the return value and jump if failed.

src/testdir/test_vim9_expr.vim

diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim
index ea79c04..321dbf9 100644
--- a/src/testdir/test_vim9_expr.vim
+++ b/src/testdir/test_vim9_expr.vim
@@ -687,6 +687,8 @@
 
   call CheckDefFailure("let x = @", "E1002:")
   call CheckDefFailure("let x = @<", "E354:")
+
+  call CheckDefFailure("let x = &notexist", "E113:")
 endfunc
 
 let g:Funcrefs = [function('add')]

src/version.c

diff --git a/src/version.c b/src/version.c
index d5108d9..c6259bc 100644
--- a/src/version.c
+++ b/src/version.c
@@ -743,6 +743,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    167,
+/**/
     166,
 /**/
     165,

src/vim9execute.c

diff --git a/src/vim9execute.c b/src/vim9execute.c
index 001d274..6865ba1 100644
--- a/src/vim9execute.c
+++ b/src/vim9execute.c
@@ -556,7 +556,8 @@
 
 		    if (ga_grow(&ectx.ec_stack, 1) == FAIL)
 			goto failed;
-		    get_option_tv(&name, &optval, TRUE);
+		    if (get_option_tv(&name, &optval, TRUE) == FAIL)
+			goto failed;
 		    *STACK_TV_BOT(0) = optval;
 		    ++ectx.ec_stack.ga_len;
 		}