patch 9.1.0149: null pointer member access when accessing 'winfixbuf' property
Problem: qf_goto_win_with_qfl_file may check if prevwin has 'winfixbuf'
set without checking if it's valid first.
Solution: Reverse the condition. Add a test, a modeline, and a missing
CheckFeature. (Searn Dewar)
closes: #14140
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
diff --git a/src/testdir/test_winfixbuf.vim b/src/testdir/test_winfixbuf.vim
index 0b15983..2dffbe1 100644
--- a/src/testdir/test_winfixbuf.vim
+++ b/src/testdir/test_winfixbuf.vim
@@ -1576,6 +1576,7 @@
" Fail vim.command if we try to change buffers while 'winfixbuf' is set
func Test_lua_command()
+ CheckFeature lua
call s:reset_all_buffers()
enew
@@ -3129,3 +3130,21 @@
call delete("middle")
call delete("last")
endfunc
+
+func Test_quickfix_switchbuf_invalid_prevwin()
+ call s:reset_all_buffers()
+
+ let [l:first, _] = s:make_simple_quickfix()
+ call assert_notequal(l:first, bufnr())
+ call assert_equal(1, winnr('$'))
+
+ set switchbuf=uselast
+ split
+ copen
+ execute winnr('#') 'quit'
+
+ call assert_fails('cfirst', 'E1513:')
+ set switchbuf&
+endfunc
+
+" vim: shiftwidth=2 sts=2 expandtab