patch 8.2.4696: delete() with "rf" argument does not report a failure
Problem: delete() with "rf" argument does not report a failure.
Solution: Return -1 if the directory could not be removed. (closes #10078)
diff --git a/src/fileio.c b/src/fileio.c
index 9ef2dbd..af915c6 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -5017,13 +5017,16 @@
vim_snprintf((char *)NameBuff, MAXPATHL, "%s/%s", exp,
((char_u **)ga.ga_data)[i]);
if (delete_recursive(NameBuff) != 0)
+ // Remember the failure but continue deleting any further
+ // entries.
result = -1;
}
ga_clear_strings(&ga);
+ if (mch_rmdir(exp) != 0)
+ result = -1;
}
else
result = -1;
- (void)mch_rmdir(exp);
vim_free(exp);
}
else