patch 8.2.3429: leaking memory when assigning to list or dict
Problem: Leaking memory when assigning to list or dict.
Solution: Free the list or dict type before overwriting it.
diff --git a/src/evalvars.c b/src/evalvars.c
index 5a26eff..4cc0fa8 100644
--- a/src/evalvars.c
+++ b/src/evalvars.c
@@ -3462,9 +3462,21 @@
if (vim9script && type != NULL)
{
if (type->tt_type == VAR_DICT && dest_tv->vval.v_dict != NULL)
- dest_tv->vval.v_dict->dv_type = alloc_type(type);
+ {
+ if (dest_tv->vval.v_dict->dv_type != type)
+ {
+ free_type(dest_tv->vval.v_dict->dv_type);
+ dest_tv->vval.v_dict->dv_type = alloc_type(type);
+ }
+ }
else if (type->tt_type == VAR_LIST && dest_tv->vval.v_list != NULL)
- dest_tv->vval.v_list->lv_type = alloc_type(type);
+ {
+ if (dest_tv->vval.v_list->lv_type != type)
+ {
+ free_type(dest_tv->vval.v_list->lv_type);
+ dest_tv->vval.v_list->lv_type = alloc_type(type);
+ }
+ }
}
// ":const var = value" locks the value