patch 8.2.3844: Vim9: no type error if assigning func(number) to func(string)
Problem: Vim9: no type error if assigning a value with type func(number) to
a variable of type func(string).
Solution: Use check_type_maybe(): return MAYBE if a runtime type check is
useful. (issue #8492)
diff --git a/src/vim9compile.c b/src/vim9compile.c
index 388308a..d6fc6d8 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -1061,6 +1061,8 @@
int silent,
int actual_is_const)
{
+ int ret;
+
if (expected == &t_bool && actual != &t_bool
&& (actual->tt_flags & TTFLAG_BOOL_OK))
{
@@ -1070,13 +1072,14 @@
return OK;
}
- if (check_type(expected, actual, FALSE, where) == OK)
+ ret = check_type_maybe(expected, actual, FALSE, where);
+ if (ret == OK)
return OK;
// If the actual type can be the expected type add a runtime check.
// If it's a constant a runtime check makes no sense.
- if ((!actual_is_const || actual == &t_any)
- && use_typecheck(actual, expected))
+ if (ret == MAYBE || ((!actual_is_const || actual == &t_any)
+ && use_typecheck(actual, expected)))
{
generate_TYPECHECK(cctx, expected, offset, where.wt_index);
return OK;