patch 9.0.0294: crash when 'cmdheight' is 0 and popup_clear() used
Problem: Crash when 'cmdheight' is 0 and popup_clear() used.
Solution: Reset "message_win" when the message popup is cleared. Close the
popup when 'cmdheight' is non-zero. Add a screendump test.
diff --git a/src/testdir/dumps/Test_cmdheight_zero_1.dump b/src/testdir/dumps/Test_cmdheight_zero_1.dump
new file mode 100644
index 0000000..6fd15a0
--- /dev/null
+++ b/src/testdir/dumps/Test_cmdheight_zero_1.dump
@@ -0,0 +1,6 @@
+>s+0&#ffffff0|o|m|e| |t|e|x|t| @65
+|~+0#4040ff13&| @73
+|~| @73
+|~| @73
+|~| @73
+|~| @73
diff --git a/src/testdir/dumps/Test_cmdheight_zero_2.dump b/src/testdir/dumps/Test_cmdheight_zero_2.dump
new file mode 100644
index 0000000..d8c3aea
--- /dev/null
+++ b/src/testdir/dumps/Test_cmdheight_zero_2.dump
@@ -0,0 +1,6 @@
+|s+0&#e0e0e08|o|m|e| >t+0&#ffffff0|e|x|t| @65
+|~+0#4040ff13&| @73
+|~| @73
+|~| @73
+|~| @73
+|~| @73
diff --git a/src/testdir/dumps/Test_cmdheight_zero_3.dump b/src/testdir/dumps/Test_cmdheight_zero_3.dump
new file mode 100644
index 0000000..ea83d3d
--- /dev/null
+++ b/src/testdir/dumps/Test_cmdheight_zero_3.dump
@@ -0,0 +1,6 @@
+|s+0&#ffffff0|o|m|e| >t|e|x|t| @65
+|~+0#4040ff13&| @73
+|~| @73
+|~| @73
+|═+0#e000002&@74
+|m|e|s@1|a|g|e| |w|i|n|d|o|w| @60
diff --git a/src/testdir/test_messages.vim b/src/testdir/test_messages.vim
index 00e942e..ffb7a20 100644
--- a/src/testdir/test_messages.vim
+++ b/src/testdir/test_messages.vim
@@ -471,4 +471,32 @@
redraw
endfunc
+func Test_cmdheight_zero_dump()
+ CheckScreendump
+
+ let lines =<< trim END
+ set cmdheight=0
+ set showmode
+ call setline(1, 'some text')
+ END
+ call writefile(lines, 'XtestCmdheight')
+ let buf = RunVimInTerminal('-S XtestCmdheight', #{rows: 6})
+ " The "-- INSERT --" indicator should not be visible.
+ call term_sendkeys(buf, "i")
+ call VerifyScreenDump(buf, 'Test_cmdheight_zero_1', {})
+
+ " The "-- VISUAL --" indicator should not be visible.
+ call term_sendkeys(buf, "\<Esc>vw")
+ call VerifyScreenDump(buf, 'Test_cmdheight_zero_2', {})
+
+ " Echo'd text is in a popup window
+ call term_sendkeys(buf, "\<Esc>:echo 'message window'\<CR>")
+ call VerifyScreenDump(buf, 'Test_cmdheight_zero_3', {})
+
+ " clean up
+ call StopVimInTerminal(buf)
+ call delete('XtestCmdheight')
+endfunc
+
+
" vim: shiftwidth=2 sts=2 expandtab