patch 9.0.1538: :wqall does not trigger ExitPre
Problem: :wqall does not trigger ExitPre. (Bart Libert)
Solution: Move preparations for :qall to a common function. (closes #12374)
diff --git a/src/ex_cmds.c b/src/ex_cmds.c
index 085467e..0fd6d10 100644
--- a/src/ex_cmds.c
+++ b/src/ex_cmds.c
@@ -2269,7 +2269,11 @@
int save_forceit = eap->forceit;
if (eap->cmdidx == CMD_xall || eap->cmdidx == CMD_wqall)
+ {
+ if (before_quit_all(eap) == FAIL)
+ return;
exiting = TRUE;
+ }
FOR_ALL_BUFFERS(buf)
{
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
index a0a7183..430ca2c 100644
--- a/src/ex_docmd.c
+++ b/src/ex_docmd.c
@@ -5957,10 +5957,11 @@
}
/*
- * ":qall": try to quit all windows
+ * Do preparations for "qall" and "wqall".
+ * Returns FAIL when quitting should be aborted.
*/
- static void
-ex_quit_all(exarg_T *eap)
+ int
+before_quit_all(exarg_T *eap)
{
if (cmdwin_type != 0)
{
@@ -5968,19 +5969,30 @@
cmdwin_result = K_XF1; // ex_window() takes care of this
else
cmdwin_result = K_XF2;
- return;
+ return FAIL;
}
// Don't quit while editing the command line.
if (text_locked())
{
text_locked_msg();
- return;
+ return FAIL;
}
if (before_quit_autocmds(curwin, TRUE, eap->forceit))
- return;
+ return FAIL;
+ return OK;
+}
+
+/*
+ * ":qall": try to quit all windows
+ */
+ static void
+ex_quit_all(exarg_T *eap)
+{
+ if (before_quit_all(eap) == FAIL)
+ return;
exiting = TRUE;
if (eap->forceit || !check_changed_any(FALSE, FALSE))
getout(0);
diff --git a/src/proto/ex_docmd.pro b/src/proto/ex_docmd.pro
index f5d7a48..3a1dc5f 100644
--- a/src/proto/ex_docmd.pro
+++ b/src/proto/ex_docmd.pro
@@ -39,6 +39,7 @@
void not_exiting(void);
int before_quit_autocmds(win_T *wp, int quit_all, int forceit);
void ex_quit(exarg_T *eap);
+int before_quit_all(exarg_T *eap);
void tabpage_close(int forceit);
void tabpage_close_other(tabpage_T *tp, int forceit);
void ex_stop(exarg_T *eap);
diff --git a/src/testdir/test_exit.vim b/src/testdir/test_exit.vim
index 9e9370e..b0446ba 100644
--- a/src/testdir/test_exit.vim
+++ b/src/testdir/test_exit.vim
@@ -81,6 +81,18 @@
\ readfile('Xtestout'))
endif
call delete('Xtestout')
+
+ " ExitPre autocommand also executed on :wqall
+ let after =<< trim [CODE]
+ au QuitPre * call writefile(["QuitPre"], "Xtestout", "a")
+ au ExitPre * call writefile(["ExitPre"], "Xtestout", "a")
+ wqall
+ [CODE]
+
+ if RunVim([], after, '')
+ call assert_equal(['QuitPre', 'ExitPre'], readfile('Xtestout'))
+ endif
+ call delete('Xtestout')
endfunc
" Test for getting the Vim exit code from v:exiting
diff --git a/src/version.c b/src/version.c
index 3a7dcb8..35a9708 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 1538,
+/**/
1537,
/**/
1536,