commit 3dddb09c98825acefa6f2d94bb369b8e00d7b3e5
author Bram Moolenaar <Bram@vim.org> Sun Jun 24 19:01:59 2018 +0200
committer Bram Moolenaar <Bram@vim.org> Sun Jun 24 19:01:59 2018 +0200
tree 157ed0076c22b082eb97d422583287abde42b572
parent d1d037e90192ab64e4cec00b9d008b33bc69d979

patch 8.1.0112: no error when using bad arguments with searchpair()

Problem:    No error when using bad arguments with searchpair().
Solution:   Add error messages.

src/testdir/test_search.vim

diff --git a/src/testdir/test_search.vim b/src/testdir/test_search.vim
index c923e9d..9b078be 100644
--- a/src/testdir/test_search.vim
+++ b/src/testdir/test_search.vim
@@ -287,16 +287,26 @@
   new
   call setline(1, ['other code here', '', '[', '" cursor here', ']'])
   4
-  let a=searchpair('\[','',']','bW')
+  let a = searchpair('\[','',']','bW')
   call assert_equal(3, a)
   set nomagic
   4
-  let a=searchpair('\[','',']','bW')
+  let a = searchpair('\[','',']','bW')
   call assert_equal(3, a)
   set magic
   q!
 endfunc
 
+func Test_searchpair_errors()
+  call assert_fails("call searchpair([0], 'middle', 'end', 'bW', 'skip', 99, 100)", 'E730: using List as a String')
+  call assert_fails("call searchpair('start', {-> 0}, 'end', 'bW', 'skip', 99, 100)", 'E729: using Funcref as a String')
+  call assert_fails("call searchpair('start', 'middle', {'one': 1}, 'bW', 'skip', 99, 100)", 'E731: using Dictionary as a String')
+  call assert_fails("call searchpair('start', 'middle', 'end', 'flags', 'skip', 99, 100)", 'E475: Invalid argument: flags')
+  call assert_fails("call searchpair('start', 'middle', 'end', 'bW', 0, 99, 100)", 'E475: Invalid argument: 0')
+  call assert_fails("call searchpair('start', 'middle', 'end', 'bW', 'func', -99, 100)", 'E475: Invalid argument: -99')
+  call assert_fails("call searchpair('start', 'middle', 'end', 'bW', 'func', 99, -100)", 'E475: Invalid argument: -100')
+endfunc
+
 func Test_searchpair_skip()
     func Zero()
 	return 0
@@ -311,8 +321,6 @@
     3 | call assert_equal(1, searchpair('{', '', '}', 'bWn', {-> 0}))
     3 | call assert_equal(1, searchpair('{', '', '}', 'bWn', function('Zero')))
     3 | call assert_equal(1, searchpair('{', '', '}', 'bWn', function('Partial', [0])))
-    " invalid argument
-    3 | call assert_equal(0, searchpair('{', '', '}', 'bWn', 0))
     bw!
 endfunc