patch 8.2.4065: computation overflow with large cound for :yank
Problem: Computation overflow with large cound for :yank.
Solution: Avoid an overflow.
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
index 7134359..f16f600 100644
--- a/src/ex_docmd.c
+++ b/src/ex_docmd.c
@@ -2374,7 +2374,10 @@
else
{
ea.line1 = ea.line2;
- ea.line2 += n - 1;
+ if (ea.line2 >= LONG_MAX - (n - 1))
+ ea.line2 = LONG_MAX; // avoid overflow
+ else
+ ea.line2 += n - 1;
++ea.addr_count;
/*
* Be vi compatible: no error message for out of range.
diff --git a/src/testdir/test_excmd.vim b/src/testdir/test_excmd.vim
index 6f648dd..731e9aa 100644
--- a/src/testdir/test_excmd.vim
+++ b/src/testdir/test_excmd.vim
@@ -704,9 +704,14 @@
throw 'Skipped: only works with 64 bit long ints'
endif
new
- call setline(1, 'text')
+ call setline(1, range(100))
call assert_fails('|.44444444444444444444444', 'E1247:')
call assert_fails('|.9223372036854775806', 'E1247:')
+
+ $
+ yank 77777777777777777777
+ call assert_equal("99\n", @")
+
bwipe!
endfunc
diff --git a/src/version.c b/src/version.c
index 5f28da3..e329775 100644
--- a/src/version.c
+++ b/src/version.c
@@ -751,6 +751,8 @@
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 4065,
+/**/
4064,
/**/
4063,